Open
Conversation
Contributor
|
Simple suggestion: include emoji images as resources. |
Author
|
Totally not a dumb question. The reason I did that is because that dict is a straight copy/paste of the output here. The intention is that if those links are updated, it will be easy to paste in the new dict straight from the API output. I suppose one could write a script to download and add all the images to the repo as resources, but it seems like a lot of effort to me for a sub par result. Getting them from the API will always get you up to date emojis. The user is guaranteed to be online anyway and these tiny files use a negligible amount of bandwidth. |
Contributor
|
@brad Thank you for the explanations! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Mariano,
This is my attempt to add emoji support (#81). Works great for me. It uses my customized version of https://gist.github.com/lepture/2011858
I customized it because the original was missing quite a few emoji. My version pulls a list from Github's API, falling back to a hardcoded version of that list if there is an error, such as Github rate limit being hit (60 requests /hr). With normal usage, the rate limit shouldn't get hit, because snakefire caches it (only hitting the API once every time the program is loaded)
I added some tests of emoji.py for good measure. Let me know what you think!