Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to further decouple the core crate from the CLI stuff, by removing the
cli
feature flag and dependency oncliclack
.To achieve this, some refactoring is in order, so that all client-facing logging is done in the
soldeer-commands
crate.This PR adds verbose and quiet flags to the
soldeer_commands
crate and averbose
parameter to thesoldeer_commands::run
function. If any verbosity is specified, the tool will skip the usage ofcliclack
for pretty-printing progress and use structured logging instead.In the CLI help:
Breaking Changes
cli
andcliclack
feature flags onsoldeer_core
have been removedsoldeer_core::install::PROGRESS_TEMPLATE
has been removedsoldeer_commands::ConfigLocation
now wraps thesoldeer_core::config::ConfigLocation
soldeer_commands::run
now takes a newverbose
parameterVerbosity::default()
orVerbose::new(0, 0)
uses cliclackVerbosity::new(1, 0)
prints errors and warningsVerbosity::new(2, 0)
prints infoVerbosity::new(3, 0)
prints debugVerbosity::new(4, 0)
prints traceVerbosity::new(0, 1)
prints nothing (ifquiet
is larger thanverbose
)soldeer_core::install::Progress
has been replaced withsoldeer_core::install::InstallMonitoring
andsoldeer_core::install::InstallProgress
Closes #208