fix(core): remove hardcoded git domains #244

puuuuh · 2025-02-01T19:23:12Z

Closes #47

Breaking changes

soldeer_core::utils::get_url_type has been removed
soldeer_core::utils::UrlType was removed
soldeer_commands::install::Install was changed to remove remote_url and add zip_url and git_url.

Signed-off-by: puuuuh <[email protected]>

crates/core/src/utils.rs

crates/commands/tests/tests-init.rs

beeb

Could you update the usage guide with the necessary changes in the cli's options?

crates/commands/src/commands/install.rs

beeb

Thanks a lot for the contribution!

mario-eth · 2025-02-05T06:32:05Z

Awesome work sir! ❤️ thank you!

Allow to use any domains with git deps

489c2ec

Signed-off-by: puuuuh <[email protected]>

beeb reviewed Feb 2, 2025

View reviewed changes

crates/core/src/utils.rs Outdated Show resolved Hide resolved

beeb reviewed Feb 2, 2025

View reviewed changes

crates/commands/tests/tests-init.rs Outdated Show resolved Hide resolved

Use UrlType and --git flag in cli instead of get_url_type euristics

0a5b46c

puuuuh force-pushed the main branch from 7e717da to 0a5b46c Compare February 3, 2025 14:06

beeb requested changes Feb 4, 2025

View reviewed changes

beeb reviewed Feb 4, 2025

View reviewed changes

crates/commands/src/commands/install.rs Outdated Show resolved Hide resolved

puuuuh and others added 3 commits February 4, 2025 18:29

Update docs, add required attr

71290de

Use --git --url instead of flag+pos argument

0d66fcb

feat: derive Display for UrlType

ed6fbac

beeb approved these changes Feb 4, 2025

View reviewed changes

mario-eth merged commit c7e8198 into mario-eth:main Feb 5, 2025
8 checks passed