feat: improve toml validation #248
Open
+107
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add logging to update module refactor: remove useless utility to read a file feat: add logging to utils feat: verbose flag feat: support RUST_LOG fix: disable tui
Also improve error for url conflict (http url and git both present)
mario-eth
reviewed
Feb 13, 2025
| @@ -859,6 +859,13 @@ fn parse_dependency(name: impl Into<String>, value: &Item) -> Result<Dependency> | |||
| } | |||
| }; | |||
|
|
|||
| // check for unallowed fields | |||
| if let Some((k, _)) = | |||
| table.iter().find(|(k, _)| !["version", "url", "git", "rev", "branch", "tag"].contains(k)) | |||
There was a problem hiding this comment.
instead of reverting, i would just throw a warning saying this field is not supported. in this way if someone wants extra fields so be it
There was a problem hiding this comment.
Makes sense, will do!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the TOML validation when reading dependencies from the config file. Extraneous fields now generate an error.
Closes #219