Fix Ctrl+C copy shortcut in SQL editor log/statistics view#476
Merged
Fix Ctrl+C copy shortcut in SQL editor log/statistics view#476
Conversation
When the statistics/log view (vmLogCtrl) was active in the SQL editor window, pressing Ctrl+C did nothing because OnMenuCopy only handled vmEditor and vmGrid modes. The frame's Edit menu accelerator captured Ctrl+C and called OnMenuCopy, which skipped the vmLogCtrl case entirely. - Add vmLogCtrl handling in OnMenuCopy to call styled_text_ctrl_stats->Copy() - Add vmLogCtrl handling in OnMenuUpdateCopy to enable Copy when text is selected in the statistics/log view Co-authored-by: mariuz <18359+mariuz@users.noreply.github.com> Agent-Logs-Url: https://github.com/mariuz/flamerobin/sessions/6e42adab-f5d3-44b9-86a6-ac8a1e0ce6a3
Copilot
AI
changed the title
[WIP] Add support for newer keyboard shortcuts in log window
Fix Ctrl+C copy shortcut in SQL editor log/statistics view
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Edit menu's Ctrl+C accelerator intercepted the keypress and called
OnMenuCopy, which had no handler forvmLogCtrlmode — so copy was silently dropped. Ctrl+Insert worked because it bypasses the wxWidgets menu accelerator system and is handled directly by Scintilla's internal key map.Changes
OnMenuCopy: AddedvmLogCtrlbranch to callstyled_text_ctrl_stats->Copy(), consistent with howOnMenuSelectAllalready handled all three view modes.OnMenuUpdateCopy: AddedvmLogCtrlbranch to enable the Copy menu item when text is selected in the stats control, usingGetSelectionStart() != GetSelectionEnd()(same pattern asTextControl::OnCommandUpdateCopy).✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.