MLE-22471 Supporting cosine-distance and other updates from code gen

[rjrudin]

Ran the Optic code generator, made a bunch of tweaks so as not to lose anything.

Added tests for cosineDistance, which was previously not supported. Also added tests for new variants of shortestPath.

[Copilot]

Pull Request Overview

This PR adds support for the new cosineDistance vector function, enhances existing vector operations and server calls, updates generated documentation to mark parameters as optional, and introduces overloads for the shortestPath plan operation (including weight).

• Added cosineDistance implementation, API, and tests
• Updated existing vector function tests for fixed output counts and introduced new vectorScore variants
• Extended shortestPath with string and weighted overloads and migrated functional tests to RowTemplate

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
VectorTest.java	Added cosineDistance test, fixed row count, and new assertions
xs_unsignedLong.html, xs_unsignedInt.html, etc.	Marked many vector/function parameters and returns as optional
VecExprImpl.java	Removed explicit null checks; added cosineDistance call
PlanBuilderImpl.java	Added shortestPath overloads with weight
VecExpr.java	Added cosineDistance API and javadoc
TestOpticOnTriples.java	Migrated shortestPath tests to RowTemplate, added weight test

Comments suppressed due to low confidence (2)

marklogic-client-api/src/main/java/com/marklogic/client/expression/VecExpr.java:90

• Update this parameter description to reference cosine distance rather than similarity, to match the new method semantics.

* @param vector1 The vector from which to calculate the cosine similarity with vector2.  (of <a href="{@docRoot}/doc-files/types/vec_vector.html">vec:vector</a>)

marklogic-client-api/src/main/java/com/marklogic/client/impl/PlanBuilderImpl.java:2269

• [nitpick] Only start and end are null-checked; consider validating path, length, and weight for consistency or document that null is acceptable for these parameters.

public ModifyPlan shortestPath(PlanExprCol start, PlanExprCol end, PlanExprCol path, PlanExprCol length, PlanExprCol weight) {

[Copilot]

Use an overload of assertEquals that includes a delta for floating-point comparisons (e.g., assertEquals(expected, actual, delta)) to avoid brittle tests.

Suggested change

	assertEquals(1.31585550308228, rows.get(0).getDouble("cosineDistance"));
	assertEquals(1.31585550308228, rows.get(0).getDouble("cosineDistance"), 1e-9);

[Copilot]

[nitpick] Consider adding back explicit null checks or documenting that null is permitted; without precondition validation, passing null may lead to unclear NPEs downstream.

Suggested change

	public ServerExpression cosineDistance(ServerExpression arg1, ServerExpression arg2) {
	public ServerExpression cosineDistance(ServerExpression arg1, ServerExpression arg2) {
	if (arg1 == null) {
	throw new IllegalArgumentException("Argument 'arg1' cannot be null.");
	}
	if (arg2 == null) {
	throw new IllegalArgumentException("Argument 'arg2' cannot be null.");
	}