Skip to content

MLE-22657 Bumped opencsv dependency to address CSV #1782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Jun 20, 2025

Also made the smoke test less bad.

Also made the smoke test less bad.
@Copilot Copilot AI review requested due to automatic review settings June 20, 2025 16:24
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the OpenCSV dependency to address CSV handling fixes and simplifies the smoke test for OpenCSVBatcherExample.

  • Updated OpenCSV from 5.10 to 5.11.1 in the examples build.
  • Simplified the JUnit smoke test by removing manual try/catch and using throws Exception for brevity.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
marklogic-client-api/src/test/java/com/marklogic/client/test/example/extension/OpenCSVBatcherTest.java Simplified testMain to a no-assert smoke test that propagates exceptions
examples/build.gradle Bumped com.opencsv:opencsv from 5.10 to 5.11.1
Comments suppressed due to low confidence (1)

marklogic-client-api/src/test/java/com/marklogic/client/test/example/extension/OpenCSVBatcherTest.java:12

  • The smoke test only verifies that no exception is thrown; consider adding assertions to validate expected behavior or side effects of OpenCSVBatcherExample.main for stronger test coverage.
	void testMain() throws Exception {

@rjrudin rjrudin merged commit 1d365f9 into develop Jun 20, 2025
2 checks passed
@rjrudin rjrudin deleted the feature/22657-bean-utils branch June 20, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants