MLE-21417/Push ML12 nightly to PDC #360
Open
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwinieski
requested review from
vitalykorolev,
pengzhouml,
barkhachoithani,
sumanthravipati and
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for pushing the ML12 nightly build to the PDC registry by updating the Jenkinsfile.
- Introduces a new variable, pdcRegistry, for the PDC registry endpoint.
- Adds conditional steps in the publishToInternalRegistry method to log in, tag, and push Docker images to the PDC registry for ML12 builds.
| @@ -13,6 +13,7 @@ emailList = '[email protected], [email protected], Sumanth | |||
| emailSecList = '[email protected]' | |||
| gitCredID = 'marklogic-builder-github' | |||
| dockerRegistry = 'ml-docker-db-dev-tierpoint.bed-artifactory.bedford.progress.com' | |||
| pdcRegistry = 'sandboxpdc.azurecr.io' | |||
There was a problem hiding this comment.
[nitpick] Consider externalizing the pdcRegistry URL into a configuration file or environment variable to simplify future updates without modifying the Jenkinsfile.
Suggested change
| pdcRegistry = 'sandboxpdc.azurecr.io' | |
| pdcRegistry = env.PDC_REGISTRY ?: 'sandboxpdc.azurecr.io' |
Copilot uses AI. Check for mistakes.
| @@ -362,9 +363,21 @@ void publishToInternalRegistry() { | |||
| } | |||
| } | |||
|
|
|||
| // Publish to private ACR repository that is used by PDC. (only ML12) | |||
| if ( params.marklogicVersion == "12" ) { | |||
There was a problem hiding this comment.
[nitpick] Consider using a named constant or configuration parameter for the Marklogic version '12' to improve readability and maintainability in future expansions.
Suggested change
| if ( params.marklogicVersion == "12" ) { | |
| if ( params.marklogicVersion == MARKLOGIC_VERSION_12 ) { |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist:
Owner:
JIRA_ID as part of branch/PR name
Rebase the branch with upstream
Squashed all commits into a single commit
Added Tests
Reviewer:
Reviewed Tests
Added to Release Wiki/Jira