forked from synthetos/TinyG
-
Notifications
You must be signed in to change notification settings - Fork 3
Add AS5600 (hardware) encoder #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
brainstorm
wants to merge
18
commits into
markmaker:feature/best-for-pnp
Choose a base branch
from
brainstorm:as5600_hw_encoder
base: feature/best-for-pnp
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add AS5600 (hardware) encoder #4
brainstorm
wants to merge
18
commits into
markmaker:feature/best-for-pnp
from
brainstorm:as5600_hw_encoder
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include min pagesize workaround for avr-gcc version 12 bug, see here: https://gcc.gnu.org/bugzilla//show_bug.cgi?id=105523
Not that it seems to make any difference.
at Mark's suggestion since settings_openpnp.h is of unknown quality.
… defaults for TinyG v8 board (sacrificing RTS/CTS for TWI since XON/XOFF flow control should work well enough without overwhelming the MCU?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of the excellent @ian-arkver work on PR #3. I hope Ian's PR gets merged (after merging ian-arkver#1) and then I can rebase this one accordingly. This is a WIP that will eventually add: