Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize defines and file formatting #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

skypanther
Copy link

  • Updates all the files to use the same #define statements, with matching names.
  • Updates the setup() function to use a common pattern for the FastLED.addLeds() function call.
  • Updates the README with more explicit instructions for customizing and using these sample.
  • Applies common formatting (Google C style with attached brackets) to all files.

These changes should make it easier to use these samples. Novices will find a common pattern, which will be easier to follow. Experienced users will be able to more quickly use each of the samples.

Thanks for these samples! They are a great help and I refer to them often.

Updates all the files to use the same #define statements, with matching names. Also updates the setup() function to use a common pattern for the FastLED.addLeds() function call. Also updates the README with more explicit instructions for customizing and using these sample.This should make it easier

These changes should make it easier to use these samples. Novices will find a common pattern, which will be easier to follow. Experienced users will be able to more quickly use each of the samples.
@marmilicious
Copy link
Owner

@skypanther Wow Tim, I'm humbled by you taking the time to help improve all these. That's a lot of changes! I'm hoping some of those changes were automated!?

@skypanther
Copy link
Author

Sorry that it's so large! It's mostly white space / indenting changes. My editor did that as I saved my other changes. The key change for each is really just standardizing the #defines and addLeds statements. I've manually tested many of the updated files, though sorry, not all of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants