Assignment#1
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Autograder results
| question | status | comment |
|---|---|---|
| Part 1 - Q1 | ❌ | data directory does not exist |
| Part 1 - Q2 | ❌ | rawdata not moved to data/raw |
| Part 1 - Q3 | ❌ | ls command not run |
| Part 1 - Q4 | ❌ | Missing directories: data/processed/server_logs, data/processed/user_logs, data/processed/event_logs |
| Part 1 - Q5 | ❌ | No server log files in data/raw |
| Part 1 - Q6 | ❌ | No user log files in data/raw; No event log files in data/raw |
| Part 1 - Q7 | ✅ | |
| Part 1 - Q8 | ❌ | data/inventory.txt does not exist |
| Part 2 | ❌ | coworker-changes branch not found in commit history |
Please address the issues listed above.
…into assignment
| # 7. For user privacy, remove all files containing IP addresses (files with "ipaddr" in the filename) from ./data/raw and ./data/processed/user_logs | ||
| rm data/raw/*ipaddr* | ||
| rm data/processed/user_logs/*ipaddr* | ||
| rf -rf ./data |
There was a problem hiding this comment.
The rf -rf ./data line should have been deleted when you resolved conflicts when merging coworker-changes branch with your branch. The syntax is incorrect and its attempting to remove data dir.
Please delete this line and submit.
| rm data/raw/*ipaddr* | ||
| rm data/processed/user_logs/*ipaddr* | ||
| rf -rf ./data | ||
| ea20676d33161a6f4d0fcd3c4f7aa5360f0f4309 |
There was a problem hiding this comment.
This is hash code which showed up when you were resolving conflict. Please delete this line of code.
anjali-deshpande-hub
left a comment
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
-
Please make the requested changes (see inline comments) and submit.
-
The PR contains 555 file changes instead of just 1 (assignment.sh). The newproject directory and its sub-directories (used for testing) have been added and committed to assignment branch. Please remove the unnecessary files. You can do so using -
git checkout assignment
git rm -r newproject
git commit -m "Remove newproject directory from PR"
git push origin assignment
Everything else looks good.
|
This is a friendly reminder to make the requested review changes in order to complete the assignment. Thank you. |
|
I tried to remove the unnecessary files, but I got this: Martes-MacBook-Air-6:assignments martevroom$ git rm -r newproject |
|
Hi! I think its because assignment branch on your local machine is out of sync with one on Github. They should be the same. Try this - This will make them identical. You will also see the newproject dir on your machine. Then, run the |
|
Thank you! I figured out I had to two directories up. Now everything should be fixed. |
3 participants
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
None.
What did you learn from the changes you have made?
There were not really changes, but this assignment was helpful with practicing what I've learned so far at the DSI course.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Not really, I tried to approach it in a straightforward way.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Yes, I had some issues in the beginning. I looked at the instructions more closely, look at my notes, and use ChatGPT. This helped me to understand some of the mistakes I made in the beginning. For instance, I forgot to use "git init ." in the beginning, and I had some issues with accessing the assignment.sh file. But I quickly understood the issues and how to solve it.
How were these changes tested?
I tested it by checking the folders mostly.
A reference to a related issue in your repository (if applicable)
No.
Checklist