Skip to content

Assignment two#2

Open
martemvroom wants to merge 4 commits intomainfrom
assignment-two
Open

Assignment two#2
martemvroom wants to merge 4 commits intomainfrom
assignment-two

Conversation

@martemvroom
Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Doing assignment 2

What did you learn from the changes you have made?

Learned to further improve my SQL skills

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

For some exercises yes, but eventually I tried to go for the most clean and straightforward way

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

It was a pretty tough exercise and took me a long time to finish! Wasn't easy to come up with the codes

How were these changes tested?

Just by running the SQL code

A reference to a related issue in your repository (if applicable)

NA

Checklist

  • I can confirm that my changes are working as intended

Copy link
Copy Markdown

@Dmytro-Bonislavskyi Dmytro-Bonislavskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @martemvroom mostly done, just take a look at some small issues like here you did not "filters the results to only the customer’s most recent visit":

SELECT *
,DENSE_RANK() OVER (
PARTITION BY customer_id
ORDER BY market_date DESC)
AS visit_number
FROM customer_purchases;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants