Add optional "serviceName" property to all service methods - #82
Open
kiwi-josh wants to merge 1 commit into
Open
Conversation
… defaulting to the existing "cap_sec" if not provided to maintain backwards compatibility
kiwi-josh
force-pushed
the
feature/optional-service-name
branch
from
September 24, 2023 21:19
37d3632 to
3d2e6ca
Compare
|
+1 but
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #51
Optionally allow serviceName to be provided when calling the methods, defaulting to the existing "cap_sec" if not provided to maintain backwards compatibility