Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Writing Feedback Generator Expedition #126

Conversation

AaronSosaRamos
Copy link
Contributor

This PR was made for implementing the new Writing Feedback Generator. Here is a payload with a file:

{
   "user": {
      "id": "string",
      "fullName": "string",
      "email": "string"
   },
   "type": "tool",
   "tool_data": {
      "tool_id": 14,
      "inputs": [
         {
            "name": "grade_level",
            "value": "university"
         },
         {
            "name": "assignment_description",
            "value": "Linear Algebra"
         },
         {
            "name": "criteria",
            "value": "Understand the concepts of vector spaces, linear transformations, and matrix operations."
         },
         {
            "name": "writing_to_review",
            "value": ""
         },
         {
            "name": "file_url",
            "value": "https://firebasestorage.googleapis.com/v0/b/kai-ai-f63c8.appspot.com/o/uploads%2F510f946e-823f-42d7-b95d-d16925293946-Linear%20Regression%20Stat%20Yale.pdf?alt=media&token=caea86aa-c06b-4cde-9fd0-42962eb72ddd"
         },
         {
            "name": "file_type",
            "value": "pdf"
         },
         {
            "name": "lang",
            "value": "en"
         }
      ]
   }
}

And here is the payload without a file:

{
   "user": {
      "id": "string",
      "fullName": "string",
      "email": "string"
   },
   "type": "tool",
   "tool_data": {
      "tool_id": 14,
      "inputs": [
         {
            "name": "grade_level",
            "value": "university"
         },
         {
            "name": "assignment_description",
            "value": "Linear Algebra"
         },
         {
            "name": "criteria",
            "value": "Understand the concepts of vector spaces, linear transformations, and matrix operations."
         },
         {
            "name": "writing_to_review",
            "value": "Linear Algebra is a foundational branch of mathematics that is widely used across multiple disciplines, including data science, engineering, physics, and computer science. It provides essential tools for analyzing and solving systems of linear equations, representing geometric transformations, and modeling real-world phenomena through matrix operations and vector spaces. By mastering concepts such as eigenvalues, eigenvectors, and linear transformations, students can apply these techniques to optimize processes, develop machine learning algorithms, and understand complex systems. Furthermore, linear algebra plays a crucial role in the development of technologies like image processing, 3D modeling, and network analysis, making its study indispensable for modern technological advancements."
         },
         {
            "name": "file_url",
            "value": ""
         },
         {
            "name": "file_type",
            "value": ""
         },
         {
            "name": "lang",
            "value": "en"
         }
      ]
   }
}

And here is the response:
image

@AaronSosaRamos AaronSosaRamos added type:documentation For issues related to improving, fixing, or creating documentation. type:enhancement For minor updates or changes that improve an existing feature or process. TOOL This is a tool that is currently being worked on type:new-feature For proposals or implementation of entirely new features or functionalities. labels Nov 28, 2024
@AaronSosaRamos AaronSosaRamos linked an issue Nov 28, 2024 that may be closed by this pull request
31 tasks
@AaronSosaRamos AaronSosaRamos changed the base branch from STAGING to Develop December 6, 2024 19:03
Copy link
Contributor

@yunusj yunusj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is document loaded added as a new file in this?
Secondly, resolve conflicts

@AaronSosaRamos
Copy link
Contributor Author

AaronSosaRamos commented Dec 9, 2024

The document_loaders.py file is "added" because I created the PR before of developing a general util file for all the tools. But is actually the same as the Develop branch.
The conflicts are solved @yunusj.

@AaronSosaRamos AaronSosaRamos requested a review from yunusj December 9, 2024 14:39
@AaronSosaRamos AaronSosaRamos merged commit de23251 into marvelai-org:Develop Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TOOL This is a tool that is currently being worked on type:documentation For issues related to improving, fixing, or creating documentation. type:enhancement For minor updates or changes that improve an existing feature or process. type:new-feature For proposals or implementation of entirely new features or functionalities.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Epic 2.14 Writing Feedback Generator
3 participants