Skip to content

Conversation

lucasbm88
Copy link
Member

@lucasbm88 lucasbm88 commented Nov 29, 2017

Now we have a CLI to build docker images.

This fixes issue #35

This first version is able to build two type of docker images:

  • base - This is the base docker image that should be extended by any other marvin image.
  • spark - This is a docker image that uses marvin base and adds spark on top of it. Ideally should be used by engines that are spark-dependent.

Requirements:

How to test:

  • Clone this branch
  • Generate a new project: marvin engine-generate
  • Customize with your code (optional)
  • Build the docker image: marvin engine-dockerbuild (run --help and play around with parameters)
  • Run the image just build: docker run -it marvinai/marvin-spark
  • Call the REST pipeline endpoint and check that everything is working fine.

Custom spark configuration:

  • If you want to use custom spark files, replace the base files in <engine_home>/docker/marvin-spark-docker/spark-conf/* and build the image.

@codecov-io
Copy link

codecov-io commented Nov 30, 2017

Codecov Report

Merging #37 into master will increase coverage by 0.75%.
The diff coverage is 23.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   49.57%   50.33%   +0.75%     
==========================================
  Files          28       25       -3     
  Lines        2104     2110       +6     
  Branches      210      211       +1     
==========================================
+ Hits         1043     1062      +19     
+ Misses       1057     1044      -13     
  Partials        4        4
Impacted Files Coverage Δ
marvin_python_toolbox/management/engine.py 27.52% <23.07%> (-0.32%) ⬇️
...es/python-engine/project_package/_compatibility.py
...emplates/python-engine/project_package/_logging.py
...on-engine/project_package/data_handler/__init__.py
marvin_python_toolbox/common/config.py 96.96% <0%> (+71.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1c170f...658b23c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants