Skip to content

Commit

Permalink
Delete assert of exitcode in TestManager (#158)
Browse files Browse the repository at this point in the history
The exitcode isn't guaranteed to be set whenever |result| is |OK|,
because the code that sets it (the caller of run_test()) might be
skipped on exception.

The code after the assert seems to correctly handle the case when
|exitcode| is |None|, so this commit just deletes the assert.
  • Loading branch information
emaxx-google authored Jan 16, 2025
1 parent 29fc072 commit 326a8fb
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion cvise/utils/testing.py
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,6 @@ def process_done_futures(self):
else:
self.pass_statistic.add_failure(self.current_pass)
if test_env.result == PassResult.OK:
assert test_env.exitcode
if self.also_interesting is not None and test_env.exitcode == self.also_interesting:
self.save_extra_dir(test_env.test_case_path)
elif test_env.result == PassResult.STOP:
Expand Down

0 comments on commit 326a8fb

Please sign in to comment.