clang_delta: Skip non-dep typedefs in replace-dependent-typedef #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emaxx-google
changed the base branch from
clang_delta--dependent-typedef-tests
to
master
Only consider typedefs that depend on other typedefs in replace-dependent-typedef. This prevents the pass from reporting a success when no actual change has been made, like in the case when a typedef belongs to and refers to a template struct (where multiple possible string representations may confuse the checks).
emaxx-google
force-pushed
the
clang_delta--dependent-typedef-error
branch
from
0943c70 to
ece8354
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only consider typedefs that depend on other typedefs in replace-dependent-typedef.
This prevents the pass from reporting a success when no actual change has been made, like in the case when a typedef belongs to and refers to a template struct (where multiple possible string representations may confuse the checks).
This fixes the problem with this heuristic highlighted in #156.
Note: essentially the same change was originally proposed in the upstream -
C-Reduce - however that project seems unmaintained at the moment:
csmith-project/creduce#281