Rewrite in Typescript: RadioGroup #308
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaki-yama
commented
May 28, 2019
| className?: string; | ||
| label?: string; | ||
| required?: boolean; | ||
| error?: any; // FIXME: should be FormElementProps.error |
There was a problem hiding this comment.
Fix this after FormElement is converted to TypeScript
zaki-yama
commented
May 28, 2019
| if (this.props.onChange) { | ||
| this.props.onChange(e, value); | ||
| } | ||
| } | ||
|
|
||
| renderControl(radio) { | ||
| renderControl(radio: any) { |
There was a problem hiding this comment.
I couldn't figure out how I can give more strict type annotation here and onChange prop.
It seems children are expected to only <Radio> component, but I didn't know how I express this.
zaki-yama
commented
May 30, 2019
| @@ -60,7 +72,6 @@ export default class RadioGroup extends React.Component { | |||
| : undefined | |||
| : undefined; | |||
|
|
|||
| delete props.onChange; | |||
There was a problem hiding this comment.
Since TypeScript doesn't recognize that a certain property is deleted, a type error occured here
<fieldset className={grpClassNames} style={grpStyles} {...props}>(related to this? microsoft/TypeScript#13783)
So I used destructuring assignment above.
|
Closed because the last PR #342 had been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref. #289
TODO: after #307 is merged, change the base branch to
3.0.