Skip to content

Cosmetic change in MainWindow#370

Merged
tinevez merged 3 commits intomasterfrom
stefanhahmann-patch-5
Apr 28, 2025
Merged

Cosmetic change in MainWindow#370
tinevez merged 3 commits intomasterfrom
stefanhahmann-patch-5

Conversation

@stefanhahmann
Copy link
Copy Markdown
Collaborator

The MainWindow layout appears a bit ugly in Linux environments. I suggest to make the window a bit wider to overcome this issue.

Before (Linux):

grafik

After (Linux):

grafik

Before (Windows):

grafik

After (Windows):

grafik

@stefanhahmann stefanhahmann self-assigned this Apr 23, 2025
@stefanhahmann stefanhahmann requested a review from tinevez April 23, 2025 11:17
@tinevez
Copy link
Copy Markdown
Contributor

tinevez commented Apr 23, 2025

Any chance we could use a smaller font size on linux instead?
My reasoning is that this window just has buttons. The text is nice but not so informative, so making room for it is not super great.
Also I would like to keep some width for later, as I would like to attach a side panel for logging.

@stefanhahmann stefanhahmann force-pushed the stefanhahmann-patch-5 branch 2 times, most recently from 80b325f to 487cee3 Compare April 24, 2025 09:02
…systems and make MainWindow a bit smaller again
@stefanhahmann stefanhahmann force-pushed the stefanhahmann-patch-5 branch from 487cee3 to d63a619 Compare April 24, 2025 09:03
@stefanhahmann
Copy link
Copy Markdown
Collaborator Author

stefanhahmann commented Apr 24, 2025

Any chance we could use a smaller font size on linux instead? My reasoning is that this window just has buttons. The text is nice but not so informative, so making room for it is not super great. Also I would like to keep some width for later, as I would like to attach a side panel for logging.

I added a commit that changes the default font for unix/linux system. Since, I did not want to make that font smaller (since a smaller font looked ugly in Linux), I still had to increase the size of the MainWindow a bit (170), but less than in the first commit (where it was 190):

After PR (Linux):
grafik

After PR (Windows):
grafik

* The CI Pipeline was not working anymore. Github seems to require this change to allow the CI to be working again
@tinevez tinevez merged commit 18a146c into master Apr 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants