fix issues with Content-Type values containing commas; #13

mat-sz · Dec 19, 2023 · 2bbcd09 · 2bbcd09
1 parent 955ee36
commit 2bbcd09
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 4 deletions.
diff --git a/__tests__/parse.test.ts b/__tests__/parse.test.ts
@@ -485,6 +485,25 @@ describe('parse', () => {
       ],
     });
   });
+
+  it('should parse Content-Type values containing commas in quoted parameters', () => {
+    const output = parse(
+      `Content-Type: application/pdf; name="Hulick, Sam_AFPS Fee.pdf"\n\nABCDEF`
+    );
+    expect(output).toMatchObject({
+      contentType: {
+        type: 'application/pdf',
+        encoding: undefined,
+        parameters: {
+          name: 'Hulick, Sam_AFPS Fee.pdf',
+        },
+      },
+      body: 'ABCDEF',
+      headers: {
+        'Content-Type': 'application/pdf; name="Hulick, Sam_AFPS Fee.pdf"',
+      },
+    });
+  });
 });
 
 describe('parseContentType', () => {

diff --git a/src/parser.ts b/src/parser.ts
@@ -37,10 +37,6 @@ const MAX_DEPTH = 99;
 export function parseHeaderValue(
   value: string
 ): { firstValue: string; parameters: Headers } | undefined {
-  if (value.includes(',')) {
-    return undefined;
-  }
-
   const split = value.split(';').map(s => s.trim());
 
   const parameters: any = {};