Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readd aims magnetism test #1137

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tpurcell90
Copy link
Contributor

@tpurcell90 tpurcell90 commented Mar 10, 2025

Summary

The aims magnetism test should now work.

Checklist

Before a pull request can be merged, the following items must be checked:

  • Code is in the standard Python style.
    The easiest way to handle this is to run the following in the correct sequence on
    your local machine. Start with running ruff and ruff format on your new code. This will
    automatically reformat your code to PEP8 conventions and fix many linting issues.
  • Doc strings have been added in the Numpy docstring format.
    Run ruff on your code.
  • Type annotations are highly encouraged. Run mypy to
    type check your code.
  • Tests have been added for any new functionality or bug fixes.
  • All linting and tests pass.

Note that the CI system will run all the above checks. But it will be much more
efficient if you already fix most errors prior to submitting the PR. It is highly
recommended that you use the pre-commit hook provided in the repository. Simply run
pre-commit install and a check will be run prior to allowing commits.

@tpurcell90
Copy link
Contributor Author

This can merge in once the pymatgen update is possible

@JaGeo
Copy link
Member

JaGeo commented Mar 10, 2025

Yeah. Should hopefully be possible soon. OpenMM tests behave weird again. Will try to fix them and then see....

@tpurcell90
Copy link
Contributor Author

No rush, I was just checking to see if that was the fail point on here since the test pass locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants