Fix WalltimeHandler crash on incomplete OUTCAR + new test#412
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #412 +/- ##
==========================================
- Coverage 53.02% 52.97% -0.05%
==========================================
Files 39 39
Lines 3508 3511 +3
==========================================
Hits 1860 1860
- Misses 1648 1651 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@shyuep could you take a look? also @esoteric-ephemera curious if you've seen this error before and if so, how you worked around it |
|
I am fine with this. Merged. |
| data like a standalone '-' instead of a float. See | ||
| https://github.com/materialsproject/pymatgen/issues/2251 | ||
| """ | ||
| os.chdir(tmp_path) |
There was a problem hiding this comment.
@janosh: FYI that better practice here would be to do monkeypatch.chdir(tmp_path) to not modify the path of the main process in the test suite.
There was a problem hiding this comment.
Never mind. I see this is addressed by the tearDown call and is done throughout the module.
There was a problem hiding this comment.
strongly agree. been meaning to overhaul the custodian test suite for a long time specifically to fix this
closes materialsproject/pymatgen#2251