Skip to content

Fix WalltimeHandler crash on incomplete OUTCAR + new test#412

Merged
shyuep merged 3 commits into
materialsproject:masterfrom
janosh:fix-walltime-handler-crash-on-incomplete-outcar
Dec 3, 2025
Merged

Fix WalltimeHandler crash on incomplete OUTCAR + new test#412
shyuep merged 3 commits into
materialsproject:masterfrom
janosh:fix-walltime-handler-crash-on-incomplete-outcar

Conversation

@janosh
Copy link
Copy Markdown
Member

@janosh janosh commented Nov 25, 2025

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.97%. Comparing base (a305609) to head (93d1ca1).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/custodian/vasp/handlers.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
- Coverage   53.02%   52.97%   -0.05%     
==========================================
  Files          39       39              
  Lines        3508     3511       +3     
==========================================
  Hits         1860     1860              
- Misses       1648     1651       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@janosh
Copy link
Copy Markdown
Member Author

janosh commented Dec 3, 2025

@shyuep could you take a look? also @esoteric-ephemera curious if you've seen this error before and if so, how you worked around it

@shyuep
Copy link
Copy Markdown
Member

shyuep commented Dec 3, 2025

I am fine with this. Merged.

@shyuep shyuep merged commit 5767f84 into materialsproject:master Dec 3, 2025
8 checks passed
@janosh janosh deleted the fix-walltime-handler-crash-on-incomplete-outcar branch December 3, 2025 20:34
data like a standalone '-' instead of a float. See
https://github.com/materialsproject/pymatgen/issues/2251
"""
os.chdir(tmp_path)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janosh: FYI that better practice here would be to do monkeypatch.chdir(tmp_path) to not modify the path of the main process in the test suite.

Copy link
Copy Markdown
Member

@Andrew-S-Rosen Andrew-S-Rosen Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind. I see this is addressed by the tearDown call and is done throughout the module.

Copy link
Copy Markdown
Member Author

@janosh janosh Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strongly agree. been meaning to overhaul the custodian test suite for a long time specifically to fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Outcar parsing error from pymatgen

4 participants