Skip to content

Conversation

@affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented Jan 7, 2025

Motivation for this change
  • for continuous function on unbounded intervals
  • by-product of the Gauss integral (in the sense that it used to prove it in a forthcoming PR (that shall provide yet another proof of the Gauss integral))
Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md

- [ ] added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Jan 7, 2025
@affeldt-aist affeldt-aist added this to the 1.9.0 milestone Jan 7, 2025
@affeldt-aist
Copy link
Member Author

@IshiguroYoshihiro Can you check if there are generalizations you wanted to do?

Copy link
Member

@t6s t6s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Latexified doc for the added lemmas will help the user, but it can be done in a separate PR.

affeldt-aist and others added 2 commits February 14, 2025 23:02
- for continuous function on unbounded intervals

Co-authored-by: IshiguroYoshihiro <[email protected]>
@affeldt-aist
Copy link
Member Author

affeldt-aist commented Feb 14, 2025

Looks good. Latexified doc for the added lemmas will help the user, but it can be done in a separate PR.

Something like that? (fyi @proux01 )
image

@t6s
Copy link
Member

t6s commented Feb 15, 2025

Looks good. Latexified doc for the added lemmas will help the user, but it can be done in a separate PR.

Something like that? (fyi @proux01 ) image

This looks very nice! There are subtle lists of hypotheses for each of these lemmas, and clarifying them by latex will be also useful.

@affeldt-aist
Copy link
Member Author

There are subtle lists of hypotheses for each of these lemmas, and clarifying them by latex will be also useful.

I was reluctant to do that because I thought that from a user point of view it is enough to know about the lemma is about and to check the exact hypotheses by going to where it is defined in the file. What about just emphasizing that the reader should go to the formal statement for the exact set of hypotheses?

@t6s
Copy link
Member

t6s commented Feb 16, 2025

Let us keep the header simple and contain only the objective of lemmas. I think I am agreeing with you on this point.
I don't think that emphasis about hypotheses is not particularly necessary because Coq will appropriately show the formal
hypotheses to the user when needed.

A desirable interface for the hypotheses would be to latex-render them when the user issues the About command,
with the markdown source for that rendering provided by the developer at each statement of lemmas.
(I remember @ybertot once suggested adding to Coq such a facility for adding extra comments to lemmas.)

Anyway, I think this PR is ready to be merged.

@affeldt-aist
Copy link
Member Author

A desirable interface for the hypotheses would be to latex-render them when the user issues the About command

which is something for which @CohenCyril might have a solution

@affeldt-aist affeldt-aist merged commit f29e974 into math-comp:master Feb 18, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ✨ This issue/PR is about adding new features enhancing the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants