-
Notifications
You must be signed in to change notification settings - Fork 65
tentative generalization of FTC2 #1446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@IshiguroYoshihiro Can you check if there are generalizations you wanted to do? |
a8d9d29 to
f21d560
Compare
t6s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Latexified doc for the added lemmas will help the user, but it can be done in a separate PR.
- for continuous function on unbounded intervals Co-authored-by: IshiguroYoshihiro <[email protected]>
Something like that? (fyi @proux01 ) |
97b5cfc to
2fdce7d
Compare
This looks very nice! There are subtle lists of hypotheses for each of these lemmas, and clarifying them by latex will be also useful. |
I was reluctant to do that because I thought that from a user point of view it is enough to know about the lemma is about and to check the exact hypotheses by going to where it is defined in the file. What about just emphasizing that the reader should go to the formal statement for the exact set of hypotheses? |
|
Let us keep the header simple and contain only the objective of lemmas. I think I am agreeing with you on this point. A desirable interface for the hypotheses would be to latex-render them when the user issues the About command, Anyway, I think this PR is ready to be merged. |
which is something for which @CohenCyril might have a solution |


Motivation for this change
Checklist
CHANGELOG_UNRELEASED.md- [ ] added corresponding documentation in the headersReference: How to document
Reminder to reviewers