Skip to content

Conversation

@affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented Apr 15, 2025

Motivation for this change

closes #1491

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md

- [ ] added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@affeldt-aist
Copy link
Member Author

This is a (rebased) copy of PR #1491
This is to have a branch that is coming from a fork instead of the upstream repo on which branch creation is not allowed anymore.

@affeldt-aist affeldt-aist mentioned this pull request Apr 15, 2025
2 tasks
@affeldt-aist
Copy link
Member Author

The original PR was already approved by @t6s and the CI is as green as it can be (the ssprove errors are not relevant here, ssprove developers have been informed) so I think it is ok to merge soon

@affeldt-aist
Copy link
Member Author

@CohenCyril this PR changes the nix configuration, is it really ok to merge it into master?

@affeldt-aist affeldt-aist merged commit c79e584 into math-comp:master Apr 16, 2025
42 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants