Functions 20250428 #1593
Merged
Functions 20250428 #1593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I find it more idiomatic to write |
affeldt-aist
force-pushed
the
functions_20250428
branch
2 times, most recently
from
a84fa8c to
4ed3339
Compare
Member
Author
|
The last commit is actually coming from the PR #1506 (the |
Member
Author
|
ping @proux01 |
Member
|
this looks good to me @proux01 can we merge? |
Collaborator
|
Sure, let's merge |
proux01
force-pushed
the
functions_20250428
branch
from
4ed3339 to
0978b8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
minor generalizations
Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers