rm forms.v

[affeldt-aist]

Motivation for this change

Checklist

• added corresponding entries in CHANGELOG_UNRELEASED.md

- [ ] added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

• PRs with several commits that make sense individually and that
  all compile are preferentially merged into master.
• PRs with disorganized commits are very likely to be squash-rebased.

Reminder to reviewers

• Read this Checklist
• Put a milestone if possible
• Check labels

[t6s]

looks good

[affeldt-aist]

looks good

The CI errors seem to be due to tentative compilations agains MathComp 2.2.0, in which, indeed, sesquilinear.v was indeed not present yet.

The last commit tentatively drops MathComp 2.2.0 @proux01 @CohenCyril

[affeldt-aist]

looks good

The CI errors seem to be due to tentative compilations agains MathComp 2.2.0, in which, indeed, sesquilinear.v was indeed not present yet.

The last commit tentatively drops MathComp 2.2.0 @proux01 @CohenCyril

It's enough to fix the opam file, the nix configuration also needs to be changed apparently, but then I'm clueless. Do you happen to know now that you've been fixing Infotheo's files?

[proux01]

For nix, just edit that line:;

analysis/.nix/config.nix

Line 54 in 7528cc1

mathcomp.override.version = "2.2.0";

(you can even remove the line entirely if you want to require 2.4.0 since it's the default with Coq 8.20, according to https://github.com/NixOS/nixpkgs/blob/8c312f9b188a5a082b9062e8d54e8e9aed4e3804/pkgs/development/coq-modules/mathcomp/default.nix#L38 )

[affeldt-aist]

For nix, just edit that line:;

analysis/.nix/config.nix

Line 54 in 7528cc1

mathcomp.override.version = "2.2.0";

(you can even remove the line entirely if you want to require 2.4.0 since it's the default with Coq 8.20, according to https://github.com/NixOS/nixpkgs/blob/8c312f9b188a5a082b9062e8d54e8e9aed4e3804/pkgs/development/coq-modules/mathcomp/default.nix#L38 )

Thanks. I was looking only at the .github files. :-(

[CohenCyril]

we should also be testing mathcomp 2.4.0

[CohenCyril]

I will open a new PR for that.

[proux01]

It's already tested in the 9.0 bundle, that's probably enough?

[CohenCyril]

There can be some weird things happening when combining different versions. I would not be willing to try my luck with the last version of mathcomp.