Skip to content

Extra ) in The Configuration Block #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bdg221
Copy link

@bdg221 bdg221 commented Mar 10, 2025

Currently, there is an extra ) at the end of the value portion of the baseURL parameter.

    baseURL:                   // URL for use with links to tags (when there is a <base> tag in effect)
       (document.getElementsByTagName('base').length === 0) ?
        '' : String(document.location).replace(/#.*$/, '')),

If the code is copied and tested as it currently is in the docs, it results in the following error in the console:
Uncaught SyntaxError: missing } after property list test.html:31:63
note: { opened at line 9, column 12test.html:9:12

While this seems quite benign, the problem is that parameter changes before this invalid line are ignored. For example, setting maxBuffer: 50 * 1024 does not get implemented due to the error which can lead to confusion.

@bdg221
Copy link
Author

bdg221 commented Mar 10, 2025

I just saw the previous PR where this was fixed, but the submitter was told that it was actually valid. I promise you it is not correct. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant