Skip to content

Update key explorer to use dialog element for help dialog. (mathjax/MathJax#3405) #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Aug 8, 2025

This PR allows the KeyExplorer to use a <dialog> element when the browser supports that, and uses the current method when that isn't available. In the latter case, we still create a dialog element, but it acts like a custom element in that case, since it isn't implemented directly.

This resolve the z-index issue reported in mathjax/MathJax#3405.

@dpvc dpvc requested a review from zorkow August 8, 2025 12:34
@dpvc dpvc added this to the v4.0.1 milestone Aug 8, 2025
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.72%. Comparing base (efcdd46) to head (b92c329).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1334   +/-   ##
========================================
  Coverage    86.72%   86.72%           
========================================
  Files          337      337           
  Lines        84145    84145           
  Branches      4769     4769           
========================================
  Hits         72971    72971           
  Misses       11151    11151           
  Partials        23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant