Skip to content

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Sep 4, 2025

This PR changes the handling of tags to make three separate mtext nodes: one for the left delimiter, one for the tag number, and one for the right delimiter.

The formatTag() and formatRef() functions now take either a string or a triple of strings to use for the tag format. If it is just a string, then parentheses, brackets, and braces are removed from the beginning and ending of the thing to make the triple, otherwise, the string is used as is (and only a single mtext will be created).

The tests are updated to take these changes into account.

@dpvc dpvc requested a review from zorkow September 4, 2025 15:04
@dpvc dpvc added this to the v4.0.1 milestone Sep 4, 2025
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.71%. Comparing base (efcdd46) to head (c97db48).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1345      +/-   ##
===========================================
- Coverage    86.72%   86.71%   -0.01%     
===========================================
  Files          337      337              
  Lines        84145    84147       +2     
  Branches      4769     4771       +2     
===========================================
- Hits         72971    72968       -3     
- Misses       11151    11156       +5     
  Partials        23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant