Skip to content

Commit

Permalink
Merge pull request #688 from mathuo/687-css-class-prefixing
Browse files Browse the repository at this point in the history 
chore: rename classes to start with dv-
  • Loading branch information
@mathuo
mathuo authored Oct 26, 2024
2 parents a202a49 + c086cab commit e074453
Show file tree
Hide file tree
Showing 34 changed files with 306 additions and 291 deletions.
32 changes: 16 additions & 16 deletions packages/dockview-core/src/__tests__/dnd/droptarget.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,15 @@ describe('droptarget', () => {
fireEvent.dragOver(element);

const target = element.querySelector(
'.drop-target-dropzone'
'.dv-drop-target-dropzone'
) as HTMLElement;
fireEvent.drop(target);
expect(position).toBe('center');

const event = new Event('dragover');
(event as any)['__dockview_droptarget_event_is_used__'] = true;
fireEvent(element, event);
expect(element.querySelector('.drop-target-dropzone')).toBeNull();
expect(element.querySelector('.dv-drop-target-dropzone')).toBeNull();
});

test('directionToPosition', () => {
Expand Down Expand Up @@ -102,7 +102,7 @@ describe('droptarget', () => {
fireEvent.dragOver(element);

const target = element.querySelector(
'.drop-target-dropzone'
'.dv-drop-target-dropzone'
) as HTMLElement;
fireEvent.drop(target);
expect(position).toBe('center');
Expand All @@ -124,7 +124,7 @@ describe('droptarget', () => {
fireEvent.dragOver(element);

const target = element.querySelector(
'.drop-target-dropzone'
'.dv-drop-target-dropzone'
) as HTMLElement;

jest.spyOn(target, 'clientHeight', 'get').mockImplementation(() => 100);
Expand Down Expand Up @@ -155,12 +155,12 @@ describe('droptarget', () => {
fireEvent.dragOver(element);

let viewQuery = element.querySelectorAll(
'.drop-target > .drop-target-dropzone > .drop-target-selection'
'.dv-drop-target > .dv-drop-target-dropzone > .dv-drop-target-selection'
);
expect(viewQuery.length).toBe(1);

const target = element.querySelector(
'.drop-target-dropzone'
'.dv-drop-target-dropzone'
) as HTMLElement;

jest.spyOn(target, 'clientHeight', 'get').mockImplementation(() => 100);
Expand All @@ -187,13 +187,13 @@ describe('droptarget', () => {
}

viewQuery = element.querySelectorAll(
'.drop-target > .drop-target-dropzone > .drop-target-selection'
'.dv-drop-target > .dv-drop-target-dropzone > .dv-drop-target-selection'
);
expect(viewQuery.length).toBe(1);
expect(droptarget.state).toBe('left');
check(
element
.getElementsByClassName('drop-target-selection')
.getElementsByClassName('dv-drop-target-selection')
.item(0) as HTMLDivElement,
{
top: '0px',
Expand All @@ -209,13 +209,13 @@ describe('droptarget', () => {
);

viewQuery = element.querySelectorAll(
'.drop-target > .drop-target-dropzone > .drop-target-selection'
'.dv-drop-target > .dv-drop-target-dropzone > .dv-drop-target-selection'
);
expect(viewQuery.length).toBe(1);
expect(droptarget.state).toBe('top');
check(
element
.getElementsByClassName('drop-target-selection')
.getElementsByClassName('dv-drop-target-selection')
.item(0) as HTMLDivElement,
{
top: '0px',
Expand All @@ -231,13 +231,13 @@ describe('droptarget', () => {
);

viewQuery = element.querySelectorAll(
'.drop-target > .drop-target-dropzone > .drop-target-selection'
'.dv-drop-target > .dv-drop-target-dropzone > .dv-drop-target-selection'
);
expect(viewQuery.length).toBe(1);
expect(droptarget.state).toBe('bottom');
check(
element
.getElementsByClassName('drop-target-selection')
.getElementsByClassName('dv-drop-target-selection')
.item(0) as HTMLDivElement,
{
top: '50%',
Expand All @@ -253,13 +253,13 @@ describe('droptarget', () => {
);

viewQuery = element.querySelectorAll(
'.drop-target > .drop-target-dropzone > .drop-target-selection'
'.dv-drop-target > .dv-drop-target-dropzone > .dv-drop-target-selection'
);
expect(viewQuery.length).toBe(1);
expect(droptarget.state).toBe('right');
check(
element
.getElementsByClassName('drop-target-selection')
.getElementsByClassName('dv-drop-target-selection')
.item(0) as HTMLDivElement,
{
top: '0px',
Expand All @@ -276,14 +276,14 @@ describe('droptarget', () => {
expect(
(
element
.getElementsByClassName('drop-target-selection')
.getElementsByClassName('dv-drop-target-selection')
.item(0) as HTMLDivElement
).style.transform
).toBe('');

fireEvent.dragLeave(target);
expect(droptarget.state).toBe('center');
viewQuery = element.querySelectorAll('.drop-target');
viewQuery = element.querySelectorAll('.dv-drop-target');
expect(viewQuery.length).toBe(0);
});

Expand Down
16 changes: 8 additions & 8 deletions packages/dockview-core/src/__tests__/dockview/components/tab.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ describe('tab', () => {
new groupMock()
);

expect(cut.element.className).toBe('tab inactive-tab');
expect(cut.element.className).toBe('dv-tab dv-inactive-tab');
});

test('that active tab has active-tab class', () => {
Expand All @@ -34,10 +34,10 @@ describe('tab', () => {
);

cut.setActive(true);
expect(cut.element.className).toBe('tab active-tab');
expect(cut.element.className).toBe('dv-tab dv-active-tab');

cut.setActive(false);
expect(cut.element.className).toBe('tab inactive-tab');
expect(cut.element.className).toBe('dv-tab dv-inactive-tab');
});

test('that an external event does not render a drop target and calls through to the group model', () => {
Expand Down Expand Up @@ -85,7 +85,7 @@ describe('tab', () => {
expect(groupView.canDisplayOverlay).toBeCalled();

expect(
cut.element.getElementsByClassName('drop-target-dropzone').length
cut.element.getElementsByClassName('dv-drop-target-dropzone').length
).toBe(0);
});

Expand Down Expand Up @@ -139,7 +139,7 @@ describe('tab', () => {
expect(groupView.canDisplayOverlay).toBeCalledTimes(0);

expect(
cut.element.getElementsByClassName('drop-target-dropzone').length
cut.element.getElementsByClassName('dv-drop-target-dropzone').length
).toBe(0);
});

Expand Down Expand Up @@ -193,7 +193,7 @@ describe('tab', () => {
expect(groupView.canDisplayOverlay).toBeCalledTimes(0);

expect(
cut.element.getElementsByClassName('drop-target-dropzone').length
cut.element.getElementsByClassName('dv-drop-target-dropzone').length
).toBe(1);
});

Expand Down Expand Up @@ -253,7 +253,7 @@ describe('tab', () => {
expect(groupView.canDisplayOverlay).toBeCalledTimes(1);

expect(
cut.element.getElementsByClassName('drop-target-dropzone').length
cut.element.getElementsByClassName('dv-drop-target-dropzone').length
).toBe(0);
});

Expand Down Expand Up @@ -313,7 +313,7 @@ describe('tab', () => {
expect(groupView.canDisplayOverlay).toBeCalledTimes(1);

expect(
cut.element.getElementsByClassName('drop-target-dropzone').length
cut.element.getElementsByClassName('dv-drop-target-dropzone').length
).toBe(0);
});
});
Loading

0 comments on commit e074453

Please sign in to comment.