Fix decoding when argument-derived aliases change - #222
Open
keilogic wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
SwiftGraphQL computes field aliases from argument values. A selection closure can be evaluated once to build the query and again to decode the response. If an argument value is dynamic, such as
Meeting.nowString(), the second evaluation can produce a different alias and make decoding miss the server response even though the response matches the sent query.The fallback only applies when exactly one response key has the same field signature, so existing exact alias decoding and ambiguous same-field selections keep their current behavior.
Fixes #197.
Verification
git diff --checkswift testbecause Swift is not installed in this Windows environment.Suggested release type: patch.