-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add privacy setting allowing to randomise config ID on the backend #22952
Open
michalkleiner
wants to merge
23
commits into
5.x-dev
Choose a base branch
from
dev-3639
base: 5.x-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkleiner
added
Enhancement
For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
c: Security
For issues that make Matomo more secure. Please report issues through HackerOne and not in Github.
c: Privacy
For issues that impact or improve the privacy.
Needs Review
PRs that need a code review
labels
Jan 20, 2025
caddoo
previously approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, I would want a second approval if possible though from someone who hasn't looked at it ( @mneudert )
mneudert
reviewed
Jan 28, 2025
plugins/PrivacyManager/tests/Fixtures/RandomizedConfigIdVisitsFixture.php
Outdated
Show resolved
Hide resolved
plugins/PrivacyManager/tests/Fixtures/RandomizedConfigIdVisitsFixture.php
Outdated
Show resolved
Hide resolved
mneudert
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: Privacy
For issues that impact or improve the privacy.
c: Security
For issues that make Matomo more secure. Please report issues through HackerOne and not in Github.
Enhancement
For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Needs Review
PRs that need a code review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When the option under Settings / Privacy/ Anonymize data is selected, every action and every visit has a random config ID assigned. It's always a new visit, the visitor is never known, and we don't have access to the last know visit (since there's none).
Ref. DEV-3639
Review