Skip to content

Use integer bins for integer data in HistogramWidget #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 15, 2024

Conversation

p-j-smith
Copy link
Contributor

Part of #239

  • Originally part of Add widgets for setting histogram bins #242 but separated out for easier reviewing
  • set the dtype for np.linspace when creating bins for HistogramWidget (so integer bin limits are used for integer images)
  • this caused the test_histogram_2D test to fail (as the test layer has integer data but float bins were being used) so I've updated the baseline image

@dstansby dstansby force-pushed the feat/integer-hist-bins branch from 2ca397b to 71f6716 Compare January 13, 2024 12:51
Update baseline images
@p-j-smith p-j-smith requested a review from dstansby January 15, 2024 11:31
@dstansby dstansby merged commit 06d4b17 into matplotlib:main Jan 15, 2024
@dstansby dstansby added this to the 2.0 milestone Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants