Skip to content

Don't PublishAllPorts as we already explicitly do :8008/8448 #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Don't PublishAllPorts as we already explicitly do :8008/8448 #772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions internal/docker/deployer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,8 +380,7 @@ func deployImage(
"complement_hs_name": hsName,
},
}, &container.HostConfig{
CapAdd: []string{"NET_ADMIN"}, // TODO : this should be some sort of option
PublishAllPorts: true,
Copy link
Collaborator

@MadLittleMods MadLittleMods Apr 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may fix issues where Complement sporadically decides that there are port conflicts, causing CI flakes.

Where are you running into the CI flakes?

I'm curious because previously you said you didn't see them in vanilla Complement runs, #761

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I don't. I'm referring to reports from others who say they have when using Complement on other projects.

CapAdd: []string{"NET_ADMIN"}, // TODO : this should be some sort of option
PortBindings: nat.PortMap{
nat.Port("8008/tcp"): []nat.PortBinding{
{
Expand Down
Loading