Update our dependencies #1798
Merged
Update our dependencies #1798
+2,680
−2,000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadzik
commented
Mar 19, 2024
| @@ -453,7 +453,7 @@ export class PgDataStore implements DataStore, ProvisioningStore { | |||
| "server" | |||
| ], | |||
| ), | |||
| [counter, homeserver || "*", server.domain], | |||
| [counter, homeserver || "*", server.domain] as any[], | |||
There was a problem hiding this comment.
New version of @types/pg is very generic-happy, and insists on these being an array of a single type. explicitely casting them as any seems like the most sensible option here.
| @@ -650,7 +650,7 @@ export class PgDataStore implements DataStore, ProvisioningStore { | |||
| if (res.rowCount === 0) { | |||
| return undefined; | |||
| } | |||
| else if (res.rowCount > 1) { | |||
| else if (res.rowCount! > 1) { | |||
There was a problem hiding this comment.
The reason for this sillyness is here: brianc/node-postgres#2967
Signed-off-by: Tadeusz „tadzik” Sośnierz <tadeusz@sosnierz.com>
Signed-off-by: Tadeusz „tadzik” Sośnierz <tadeusz@sosnierz.com>
Half-Shot
reviewed
Mar 21, 2024
package.json
Outdated
| @@ -44,47 +44,47 @@ | |||
| "matrix-appservice-bridge": "^9.0.1", | |||
There was a problem hiding this comment.
You can still update to 10, you just need to add nedb as a dependency :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some are held back due to them requiring ESM (to be considered separately). That'd be
escape-string-regexpandquick-lru.jasminefrom 4.0 onwards introduces a weird (seemingly) async bug withroom setup link endpoint should create a M<--->I link for a channel that has capital letters in it. Afair we're planning to move away from Jasmine anyway, so it's probably not worth spending time on that now.matrix-bot-sdkis held back due to it droppingnedb, which we still support – perhaps it's the right time to drop it here as well though?