Skip to content
This repository was archived by the owner on Dec 12, 2022. It is now read-only.

Fix - Contact List screen doesn't update user's avatar immediately #825

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,14 @@ Changes to be released in next version
* MXKAttachment: Adapt removal of `mimetype` fields (vector-im/element-ios/issues/4303).

🐛 Bugfix

* MXKContactField: Fix the issue of downloading avatar

* MXKCallViewController: Fix status text of a remotely held call.
* MXKCallViewController: Fix avatar image for outgoing on hold calls.
* MXKRoomViewController: Fix virtual timeline issues.


⚠️ API Changes
* Exposed methods for sending audio files and voice messages (vector-im/element-ios/issues/4090).

Expand Down
9 changes: 5 additions & 4 deletions MatrixKit/Models/Contact/MXKContactField.m
Original file line number Diff line number Diff line change
Expand Up @@ -159,20 +159,21 @@ - (void)downloadAvatarImage:(CGSize)avatarSize
}
else
{
NSString *downloadId = [MXMediaManager thumbnailDownloadIdForMatrixContentURI:_matrixAvatarURL inFolder:kMXMediaManagerAvatarThumbnailFolder toFitViewSize:avatarSize withMethod:MXThumbnailingMethodCrop];
downloadId = [MXMediaManager thumbnailDownloadIdForMatrixContentURI:_matrixAvatarURL inFolder:kMXMediaManagerAvatarThumbnailFolder toFitViewSize:avatarSize withMethod:MXThumbnailingMethodCrop];
MXMediaLoader* loader = [MXMediaManager existingDownloaderWithIdentifier:downloadId];
[[NSNotificationCenter defaultCenter] removeObserver:self name:kMXMediaLoaderStateDidChangeNotification object:nil];
[[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(onMediaDownloadEnd:) name:kMXMediaLoaderStateDidChangeNotification object:loader];

if (!loader && mediaManager)
{
[mediaManager downloadThumbnailFromMatrixContentURI:_matrixAvatarURL
loader = [mediaManager downloadThumbnailFromMatrixContentURI:_matrixAvatarURL
withType:nil
inFolder:kMXMediaManagerAvatarThumbnailFolder
toFitViewSize:avatarSize
withMethod:MXThumbnailingMethodCrop
success:nil
failure:nil];
}
[[NSNotificationCenter defaultCenter] removeObserver:self name:kMXMediaLoaderStateDidChangeNotification object:nil];
[[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(onMediaDownloadEnd:) name:kMXMediaLoaderStateDidChangeNotification object:loader];
}
}
}
Expand Down