Skip to content

Support unread thread notifications in SSS mode #4770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Mar 28, 2025

This adds support for reading unread_thread_notifications in SSS mode as we do in regular sync mode.

I've proposed adding this to the SSS MSC and I've implemented it in Synapse.

Also factors out the block of code that does it as it's common to sync v2 and SSS (but too sync specific to put in room, plus room.ts is already huge).

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant