-
Notifications
You must be signed in to change notification settings - Fork 279
feat(event cache store): add an IndexedDB implementation #4617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(event cache store): add an IndexedDB implementation #4617
Conversation
crates/matrix-sdk-indexeddb/src/event_cache_store/idb_operations.rs
Outdated
Show resolved
Hide resolved
crates/matrix-sdk-indexeddb/src/event_cache_store/indexeddb_serializer.rs
Show resolved
Hide resolved
migration_conflict_strategy: MigrationConflictStrategy, | ||
} | ||
|
||
impl IndexeddbEventCacheStoreBuilder { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follows the same pattern as state_store, not sure if this is wanted or not.
}; | ||
|
||
// let store_config = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be removed later
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4617 +/- ##
==========================================
+ Coverage 85.71% 85.73% +0.01%
==========================================
Files 291 291
Lines 33323 33322 -1
==========================================
+ Hits 28563 28568 +5
+ Misses 4760 4754 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Be aware that #4632 is likely to create a non-negligible conflict with your patches. The new methods to load chunk from the event cache are going to be simpler and will allow to incrementally load the chunks. |
db030c7
to
ceac8ca
Compare
ceac8ca
to
db030c7
Compare
This PR is WIP.
This PR is meant to add a EventCache store for the the
matrix-sdk-indexeddb
crate of the SDK meant to be used in WASM contexts. Similar to the sqlite implementation is supposed to provide a disk persisted implementation for storing Events in LinkedChunks.It follows the general structure of
matrix-sdk-indexeddb/src/crypto_store
andmatrix-sdk-indexeddb/src/state_store
, a new modulematrix-sdk-indexeddb/src/event_cache_store
has been added.There are still many TODOs and questions in the codebase to which I would appreciate some guidance from the SDK maintainers.
Signed-off-by: Oscar Franco