forked from martynsmith/node-irc
-
Notifications
You must be signed in to change notification settings - Fork 32
Add support for message tags #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Half-Shot
wants to merge
10
commits into
master
Choose a base branch
from
hs/message-tag-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4118413
Message tag support
Half-Shot 8822d9f
Use capability negotiations
Half-Shot 79cb54e
Ensure we don't break simple commands
Half-Shot d524393
changelog
Half-Shot 2619f39
Merge branch 'master' into hs/message-tag-support
Half-Shot 18b1420
Test escape normal chars
Half-Shot 8d9ee82
also escape \.
Half-Shot 3cb1e29
Additional capabilities
Half-Shot a515f96
Add tests without prefix
Half-Shot 46a6e1b
Start to support without prefixes
Half-Shot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Add support for [message tags](https://ircv3.net/specs/extensions/message-tags). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -101,36 +101,87 @@ | |
"args": ["#channel", "so : colons: :are :: not a problem ::::"] | ||
}, | ||
":nick!user@host PRIVMSG #channel :\u000314,01\u001fneither are colors or styles\u001f\u0003": { | ||
"opts": { | ||
"stripColors": true | ||
}, | ||
"prefix": "nick!user@host", | ||
"nick": "nick", | ||
"user": "user", | ||
"host": "host", | ||
"command": "PRIVMSG", | ||
"rawCommand": "PRIVMSG", | ||
"commandType": "normal", | ||
"args": ["#channel", "neither are colors or styles"], | ||
"stripColors": true | ||
"args": ["#channel", "neither are colors or styles"] | ||
}, | ||
":nick!user@host PRIVMSG #channel :\u000314,01\u001fwe can leave styles and colors alone if desired\u001f\u0003": { | ||
"opts": { | ||
"stripColors": false | ||
}, | ||
"prefix": "nick!user@host", | ||
"nick": "nick", | ||
"user": "user", | ||
"host": "host", | ||
"command": "PRIVMSG", | ||
"rawCommand": "PRIVMSG", | ||
"commandType": "normal", | ||
"args": ["#channel", "\u000314,01\u001fwe can leave styles and colors alone if desired\u001f\u0003"], | ||
"stripColors": false | ||
"args": ["#channel", "\u000314,01\u001fwe can leave styles and colors alone if desired\u001f\u0003"] | ||
}, | ||
":pratchett.freenode.net 324 nodebot #ubuntu +CLcntjf 5:10 #ubuntu-unregged": { | ||
"prefix": "pratchett.freenode.net", | ||
"server": "pratchett.freenode.net", | ||
"@msgid=63E1033A051D4B41B1AB1FA3CF4B243E :nick!user@host PRIVMSG #channel :Hello!": { | ||
"opts": { | ||
"supportsMessageTags": true | ||
}, | ||
"prefix": "nick!user@host", | ||
"nick": "nick", | ||
"user": "user", | ||
"host": "host", | ||
"command": "PRIVMSG", | ||
"rawCommand": "PRIVMSG", | ||
"commandType": "normal", | ||
"tags": [ [ "msgid", "63E1033A051D4B41B1AB1FA3CF4B243E" ] ], | ||
"args": ["#channel", "Hello!"] | ||
}, | ||
"@+example=raw+:=,escaped\\:\\s\\\\ :[email protected] PRIVMSG #channel :Message": { | ||
"opts": { | ||
"supportsMessageTags": true | ||
}, | ||
"user": "user", | ||
"nick": "nick", | ||
"prefix": "[email protected]", | ||
"host": "example.com", | ||
"command": "PRIVMSG", | ||
"rawCommand": "PRIVMSG", | ||
"commandType": "normal", | ||
"tags": [ [ "+example", "raw+:=,escaped; \\" ] ], | ||
"args": ["#channel", "Message"] | ||
}, | ||
"@label=123;msgid=abc;+example-client-tag=example-value :[email protected] TAGMSG #channel": { | ||
"opts": { | ||
"supportsMessageTags": true | ||
}, | ||
"prefix": "[email protected]", | ||
"nick": "nick", | ||
"user": "user", | ||
"host": "example.com", | ||
"command": "TAGMSG", | ||
"rawCommand": "TAGMSG", | ||
"commandType": "normal", | ||
"tags":[ [ "label", "123" ], [ "msgid", "abc" ], [ "+example-client-tag", "example-value" ] ], | ||
"args": ["#channel"] | ||
}, | ||
":host.foo.bar 324 nodebot #ubuntu +CLcntjf 5:10 #ubuntu-unregged": { | ||
"prefix": "host.foo.bar", | ||
"server": "host.foo.bar", | ||
"command": "rpl_channelmodeis", | ||
"rawCommand": "324", | ||
"commandType": "reply", | ||
"args": ["nodebot", "#ubuntu", "+CLcntjf", "5:10", "#ubuntu-unregged"] | ||
}, | ||
"PING mynick": { | ||
"args": [ "mynick" ], | ||
"commandType": "normal", | ||
"command": "PING", | ||
"rawCommand": "PING" | ||
} | ||
|
||
}, | ||
"433-before-001": { | ||
"sent": [ | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.