Fix when 'registered' is emitted #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
approved these changes
Jul 26, 2021
Don't emit registered on SASL replies, because the nick may not be correct. Also always emit registered on RPL_WELCOME, because that will only be sent after CAP END anyways. Fixes #74. Signed off by Emerson Veenstra <[email protected]>
Added it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't emit registered on SASL replies, because the nick may not be
correct. Also always emit registered on RPL_WELCOME, because that
will only be sent after CAP END anyways. Fixes #74.
Signed off by Emerson Veenstra [email protected]