Fix "inbound federation redacts events from erased users" #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the HS under test remains in the room so we can query the event which should be redacted. Fixes #1203.
squahtx
approved these changes
Mar 4, 2022
|
I think the dendrite failures are covered by #1119. |
richvdh
added a commit
that referenced
this pull request
Mar 31, 2022
PR #1205 added a call to `matrix_join_room`, but did not await the result, which resulted in a bunch of warnings: ``` ** Calling ->then in void context at tests/10apidoc/33room-members.pl line 82. ** IO::Async::Future=HASH(0x557d6befbf40) IO::Async::Future=HASH(0x557d6befbf40) lost a sequence Future at /home/rav/lib/perl5/Net/Async/HTTP/Connection.pm line 472. ``` Waiting for the join to complete before proceeding fixes the warnings.
richvdh
added a commit
that referenced
this pull request
Mar 31, 2022
PR #1205 added a call to `matrix_join_room`, but did not await the result, which resulted in a bunch of warnings: ``` ** Calling ->then in void context at tests/10apidoc/33room-members.pl line 82. ** IO::Async::Future=HASH(0x557d6befbf40) IO::Async::Future=HASH(0x557d6befbf40) lost a sequence Future at /home/rav/lib/perl5/Net/Async/HTTP/Connection.pm line 472. ``` Waiting for the join to complete before proceeding fixes the warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the HS under test remains in the room so we can query the event
which should be redacted.
Fixes #1203.