Synapse: increase presence ratelimit for tests #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ratelimit is introduced in element-hq/synapse#18000 and causes some existing Sytests to fail. Increase the ratelimit in Sytest's Synapse config so tests pass again.
3 tasks
devonh
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Shoud these be the same values as used for complement tests though?
ie. 9999 (element-hq/synapse@62b5e96)
Nah, 1000/second is more than enough for these tests (that typically only send <5 presence events). it may be nice to unify with Complement for consistency - but that should be a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ratelimit is introduced in element-hq/synapse#18000 and causes some existing Sytests to fail for Synapse.
Increase the ratelimit in Sytest's Synapse config so tests pass again.
Note: I've re-pushed element-hq/synapse#18000 branch to https://github.com/element-hq/synapse/tree/set-presence-ratelimit so that the Sytest PR's CI will test that branch instead of
develop.