Skip to content

Commit

Permalink
replace moment with humanize-duration
Browse files Browse the repository at this point in the history
  • Loading branch information
matt-deboer committed Oct 10, 2017
1 parent 8d8d844 commit 63c8dcb
Show file tree
Hide file tree
Showing 11 changed files with 25 additions and 22 deletions.
9 changes: 5 additions & 4 deletions pkg/ui/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@
"flexboxgrid": "6.3.1",
"font-awesome": "4.7.0",
"history": "^4.5.1",
"humanize-duration": "^3.10.1",
"js-yaml": "^3.8.4",
"json-stream": "^1.0.0",
"longest-common-subsequence": "^1.0.4",
"material-ui": "^0.18.0",
"material-ui-chip-input": "^0.14.0",
"moment": "^2.18.1",
"node-interval-tree": "^1.2.0",
"prop-types": "^15.5.10",
"query-string": "^4.3.4",
Expand Down
4 changes: 2 additions & 2 deletions pkg/ui/src/components/ClusterPage.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { addFilter, removeFilter, removeResource } from '../state/actions/cluste
import sizeMe from 'react-sizeme'
import {Tabs, Tab} from 'material-ui/Tabs'
import FilterTable from './filter-table/FilterTable'
import * as moment from 'moment'
import { toHumanizedAge } from './converters'

import ChipInput from 'material-ui-chip-input'
import Chip from 'material-ui/Chip'
Expand Down Expand Up @@ -408,7 +408,7 @@ class ClusterPage extends React.Component {
// return <IconMore color={'rgba(0,0,0,0.4)'} hoverColor={'rgba(0,0,0,0.87)'} data-rh="Actions..."/>
case 'age':
let age = Date.now() - Date.parse(row.metadata.creationTimestamp)
return moment.duration(age).humanize()
return toHumanizedAge(age)
case 'status':
return resourceStatusIcons[row.statusSummary]
default:
Expand Down
2 changes: 1 addition & 1 deletion pkg/ui/src/components/ResourceGroup.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { routerActions } from 'react-router-redux'
import { connect } from 'react-redux'
import { addFilter, removeFilter, removeResource } from '../state/actions/access'
import FilterTable from './filter-table/FilterTable'
import * as moment from 'moment'
import { toHumanizedAge } from './converters'

import ChipInput from 'material-ui-chip-input'
import Chip from 'material-ui/Chip'
Expand Down
4 changes: 2 additions & 2 deletions pkg/ui/src/components/WorkloadsPage.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { connect } from 'react-redux'
import { addFilter, removeFilter, removeResource, scaleResource } from '../state/actions/workloads'
import sizeMe from 'react-sizeme'
import FilterTable from './filter-table/FilterTable'
import * as moment from 'moment'

import { withRouter } from 'react-router-dom'
import { linkForResource } from '../routes'
Expand All @@ -18,6 +17,7 @@ import IconMore from 'material-ui/svg-icons/navigation/more-horiz'
import Paper from 'material-ui/Paper'

import { arraysEqual } from '../comparators'
import { toHumanizedAge } from '../converters'
import { resourceStatus as resourceStatusIcons } from './icons'
import { compareStatuses } from '../utils/resource-utils'

Expand Down Expand Up @@ -462,7 +462,7 @@ class WorkloadsPage extends React.Component {
return <IconMore color={'rgba(0,0,0,0.4)'} hoverColor={'rgba(0,0,0,0.87)'} data-rh="Actions..."/>
case 'age':
let age = Date.now() - Date.parse(row.metadata.creationTimestamp)
return moment.duration(age).humanize()
return toHumanizedAge(age)
case 'status':
return <div style={styles.statusIcon}>{resourceStatusIcons[row.statusSummary]}</div>
case 'pods':
Expand Down
4 changes: 2 additions & 2 deletions pkg/ui/src/components/access/ResourcesTab.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { connect } from 'react-redux'
import { addFilter, removeFilter, removeResource } from '../../state/actions/access'
import sizeMe from 'react-sizeme'
import FilterTable from '../filter-table/FilterTable'
import * as moment from 'moment'
import { toHumanizedAge } from '../../converters'

import { withRouter } from 'react-router-dom'
import { linkForResource } from '../../routes'
Expand Down Expand Up @@ -308,7 +308,7 @@ class ResourcesTab extends React.Component {
return <IconMore color={'rgba(0,0,0,0.4)'} hoverColor={'rgba(0,0,0,0.87)'} data-rh="Actions..."/>
case 'age':
let age = Date.now() - Date.parse(row.metadata.creationTimestamp)
return moment.duration(age).humanize()
return toHumanizedAge(age)
case 'status':
return <div style={styles.statusIcon}>{resourceStatusIcons[row.statusSummary]}</div>
case 'pods':
Expand Down
4 changes: 2 additions & 2 deletions pkg/ui/src/components/cluster/NodesTab.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { connect } from 'react-redux'
import { addFilter, removeFilter, removeResource } from '../../state/actions/cluster'
import sizeMe from 'react-sizeme'
import FilterTable from '../filter-table/FilterTable'
import * as moment from 'moment'
import { toHumanizedAge } from '../../converters'

import { withRouter } from 'react-router-dom'
import { linkForResource } from '../../routes'
Expand Down Expand Up @@ -397,7 +397,7 @@ class NodesTab extends React.Component {
// return <IconMore color={'rgba(0,0,0,0.4)'} hoverColor={'rgba(0,0,0,0.87)'} data-rh="Actions..."/>
case 'age':
let age = Date.now() - Date.parse(row.metadata.creationTimestamp)
return moment.duration(age).humanize()
return toHumanizedAge(age)
case 'status':
return resourceStatusIcons[row.statusSummary]
default:
Expand Down
4 changes: 2 additions & 2 deletions pkg/ui/src/components/cluster/PersistentVolumesTab.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { connect } from 'react-redux'
import { addFilter, removeFilter, removeResource } from '../../state/actions/cluster'
import sizeMe from 'react-sizeme'
import FilterTable from '../filter-table/FilterTable'
import * as moment from 'moment'
import { toHumanizedAge } from './converters'

import ChipInput from 'material-ui-chip-input'
import Chip from 'material-ui/Chip'
Expand Down Expand Up @@ -87,7 +87,7 @@ export default class StorageClassesTab extends React.Component {
},
render: function(r) {
let age = Date.now() - Date.parse(r.metadata.creationTimestamp)
return moment.duration(age).humanize()
return toHumanizedAge(age)
}
},
]
Expand Down
4 changes: 2 additions & 2 deletions pkg/ui/src/components/cluster/ResourceQuotasTab.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

import React from 'react'
import { white } from 'material-ui/styles/colors'
import * as moment from 'moment'
import { toHumanizedAge } from '../../converters'
import ClusterResourceTab from './ClusterResourceTab'

const styles = {
Expand Down Expand Up @@ -61,7 +61,7 @@ export default class StorageClassesTab extends React.Component {
},
render: function(r) {
let age = Date.now() - Date.parse(r.metadata.creationTimestamp)
return moment.duration(age).humanize()
return toHumanizedAge(age)
}
},
]
Expand Down
4 changes: 2 additions & 2 deletions pkg/ui/src/components/cluster/StorageClassesTab.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

import React from 'react'
import { white } from 'material-ui/styles/colors'
import * as moment from 'moment'
import { toHumanizedAge } from '../../converters'
import ClusterResourceTab from './ClusterResourceTab'

const styles = {
Expand Down Expand Up @@ -61,7 +61,7 @@ export default class StorageClassesTab extends React.Component {
},
render: function(r) {
let age = Date.now() - Date.parse(r.metadata.creationTimestamp)
return moment.duration(age).humanize()
return toHumanizedAge(age)
}
},
]
Expand Down
6 changes: 4 additions & 2 deletions pkg/ui/src/converters.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import * as moment from 'moment'
// import * as moment from 'moment'
import humanizeDuration from 'humanize-duration'

/**
*
Expand Down Expand Up @@ -58,7 +59,8 @@ export function fixUnits(number, units) {

export function toHumanizedAge(timestamp) {
let age = Date.now() - Date.parse(timestamp)
let humanized = moment.duration(age).humanize()
// let humanized = moment.duration(age).humanize()
let humanized = humanizeDuration(age, {largest: 1})
return humanized.replace("a few ", "")
}

Expand Down

0 comments on commit 63c8dcb

Please sign in to comment.