Skip to content

Commit

Permalink
fix loading spinner moar better
Browse files Browse the repository at this point in the history
  • Loading branch information
matt-deboer committed Oct 30, 2017
1 parent afa22ee commit 86504df
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion pkg/ui/src/containers/AccessControlsInfo.js
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ class AccessControlsInfo extends React.Component {
{resourceInfoPage}
{resourceNotFound}

<LoadingSpinner loading={fetching && (!this.state.resource || this.state.resource.notFound)} />
<LoadingSpinner loading={!this.state.resource || (this.state.resource.notFound && fetching)} />
</div>)
}
}))
2 changes: 1 addition & 1 deletion pkg/ui/src/containers/ClusterInfo.js
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ class ClusterInfo extends React.Component {
{resourceInfoPage}
{resourceNotFound}

<LoadingSpinner loading={fetching && (!this.state.resource || this.state.resource.notFound)} />
<LoadingSpinner loading={!this.state.resource || (this.state.resource.notFound && fetching)} />
</div>)
}
}))
2 changes: 1 addition & 1 deletion pkg/ui/src/containers/WorkloadInfo.js
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ class WorkloadInfo extends React.Component {
{resourceInfoPage}
{resourceNotFound}

<LoadingSpinner loading={fetching && (!this.state.resource || this.state.resource.notFound)} />
<LoadingSpinner loading={!this.state.resource || (this.state.resource.notFound && fetching)} />
</div>
)
}
Expand Down

0 comments on commit 86504df

Please sign in to comment.