don't sort null

matt-deboer · Oct 11, 2017 · c5c081e · c5c081e
1 parent 2b3dd6d
commit c5c081e
Showing 1 changed file with 13 additions and 11 deletions.
diff --git a/pkg/ui/src/components/dashboard/NamespaceBarChart.js b/pkg/ui/src/components/dashboard/NamespaceBarChart.js
@@ -109,17 +109,19 @@ class NamespaceBarChart extends React.PureComponent {
       }
     }
 
-    items[this.state.selectBy].sort((a,b)=> {
-      let aSelected = (a.name in this.props.selectedNamespaces)
-      let bSelected = (b.name in this.props.selectedNamespaces)
-      if (aSelected && !bSelected) {
-        return -1
-      } else if (!aSelected && bSelected) {
-        return 1
-      } else {
-        return a.name.localeCompare(b.name)
-      }
-    })
+    if (items[this.state.selectBy]) {
+      items[this.state.selectBy].sort((a,b)=> {
+        let aSelected = (a.name in this.props.selectedNamespaces)
+        let bSelected = (b.name in this.props.selectedNamespaces)
+        if (aSelected && !bSelected) {
+          return -1
+        } else if (!aSelected && bSelected) {
+          return 1
+        } else {
+          return a.name.localeCompare(b.name)
+        }
+      })
+    }
 
     return (
       <div style={{...styles.wrapper, ...props.style}} className="row namespace-panel">