scoped template and ability to pass available components #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattelen
reviewed
May 26, 2023
| const methodsFromProps = buildFromProps(parent, methodKeys); | ||
| const finalProps = merge([ | ||
| passthrough.$data, | ||
| passthrough.$props, | ||
| methodsFromProps, | ||
| this.templateProps, | ||
| ]); | ||
| const components = this.scoped ? this.templateComponents : { |
There was a problem hiding this comment.
components is already defined earlier, so my compiler to bugging out on this. Can you tweak this?
| type: Object, | ||
| default: () => ({}), | ||
| }, | ||
| scoped: Boolean, |
There was a problem hiding this comment.
Shall we add a default to this? I'm thinking a default of false, then it's backward compatible.
|
Thanks @davidmeirlevy for spending time on this! I get where you are coming from and I think this is a good idea. I've made some comments on the file - once you've fixed those issues, I'll test the code itself. Thanks |
|
hi! don't think I forgot this fix :) I have some other bugs to fix in my app, and I'll handle this PR too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought it can be safer if I make the template as scoped a possible.
probably there's still work here, but the idea is to pass the components it should be able to compile, and use only the props given in
:template-props={}.@mattelen what do you say?