[EVM][InlineCost] Set threshold to a small value when BB is unreachable-terminated #867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirradosavljevic
force-pushed
the
evm_allow_size_growth_in_inlinecost
branch
from
dc11487 to
4d393ff
Compare
|
|
|
📊 Excel Report Available Benchmarks measured for:
|
vladimirradosavljevic
force-pushed
the
evm_allow_size_growth_in_inlinecost
branch
11 times, most recently
from
d9d33cb to
9dbc203
Compare
vladimirradosavljevic
changed the title
akiramenai
force-pushed
the
evm_allow_size_growth_in_inlinecost
branch
from
9dbc203 to
78a86b0
Compare
akiramenai
force-pushed
the
evm_allow_size_growth_in_inlinecost
branch
2 times, most recently
from
ea56e72 to
d317fe0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #867 +/- ##
==========================================
+ Coverage 30.07% 30.08% +0.01%
==========================================
Files 2442 2442
Lines 807946 807951 +5
Branches 176475 176476 +1
==========================================
+ Hits 242985 243088 +103
+ Misses 522792 522694 -98
Partials 42169 42169 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vladimirradosavljevic
force-pushed
the
evm_allow_size_growth_in_inlinecost
branch
from
d317fe0 to
6af3496
Compare
akiramenai
force-pushed
the
evm_allow_size_growth_in_inlinecost
branch
from
6af3496 to
0f1095d
Compare
akiramenai
requested changes
Sep 8, 2025
…alue when BB is unreachable-terminated Add positive and negative tests to show why in some cases is preferable to inline when BB is unreachable-terminated. Functions callee_inline is taken from real world example where inlining this function reduces one SLOAD after optimizations (we have the same load from the callers and in the callee). Signed-off-by: Vladimir Radosavljevic <[email protected]>
…le-terminated For EVM, to return from the contract we are using different instructions (e.g. return, revert) which are followed by unreachable. In the Inliner heuristic, if BB is unreachable-terminated threshold is set to 0 and these callsites are unlikely to be inlined. Instead, add small threshold and continue to calculate cost model, since in some cases we benefit from inlining. Signed-off-by: Vladimir Radosavljevic <[email protected]>
vladimirradosavljevic
force-pushed
the
evm_allow_size_growth_in_inlinecost
branch
from
0f1095d to
eff88db
Compare
akiramenai
approved these changes
Sep 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For EVM, to return from the contract we are using different instructions (e.g. return, revert) which are followed by unreachable. In the Inliner heuristic, if BB is unreachable-terminated threshold is set to 0 and these callsites are unlikely to be inlined. Instead, add small threshold and continue to calculate cost model, since in some cases we benefit from inlining.