Skip to content

[EVM] Fold Or Jumpi #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[EVM] Fold Or Jumpi #870

wants to merge 5 commits into from

Conversation

akiramenai
Copy link
Collaborator

No description provided.

@akiramenai akiramenai marked this pull request as draft July 30, 2025 09:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 30, 2025 •
edited
Loading 

Results for: evm ir-llvm EVMInterpreter
╔═╡ Size (-%) ╞═══════════════════════╡ All E +M3B3 ╞═╗
║ Best                                          0.478 ║
║ Worst                                         0.000 ║
║ Total                                         0.001 ║
╠═╡ Cycles (-%) ╞═════════════════════╡ All E +M3B3 ╞═╣
║ Best                                          0.871 ║
║ Worst                                        -0.182 ║
║ Total                                         0.000 ║
╠═╡ Ergs (-%) ╞═══════════════════════╡ All E +M3B3 ╞═╣
║ Best                                          0.176 ║
║ Worst                                        -0.020 ║
║ Total                                         0.000 ║
╠══╡ Gas (-%) ╞═══════════════════════╡ All E +M3B3 ╞═╣
║ Best                                          0.904 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═══════════════════════╡ All E +MzB3 ╞═╗
║ Best                                          0.485 ║
║ Worst                                         0.000 ║
║ Total                                         0.001 ║
╠═╡ Cycles (-%) ╞═════════════════════╡ All E +MzB3 ╞═╣
║ Best                                          1.309 ║
║ Worst                                         0.000 ║
║ Total                                         0.001 ║
╠═╡ Ergs (-%) ╞═══════════════════════╡ All E +MzB3 ╞═╣
║ Best                                          0.909 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠══╡ Gas (-%) ╞═══════════════════════╡ All E +MzB3 ╞═╣
║ Best                                          0.984 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═══════════════════════╡ All Y +M3B3 ╞═╗
║ Best                                          4.342 ║
║ Worst                                         0.000 ║
║ Total                                         0.948 ║
╠═╡ Cycles (-%) ╞═════════════════════╡ All Y +M3B3 ╞═╣
║ Best                                          3.810 ║
║ Worst                                        -0.211 ║
║ Total                                         0.029 ║
╠═╡ Ergs (-%) ╞═══════════════════════╡ All Y +M3B3 ╞═╣
║ Best                                          3.359 ║
║ Worst                                        -0.026 ║
║ Total                                         0.048 ║
╠══╡ Gas (-%) ╞═══════════════════════╡ All Y +M3B3 ╞═╣
║ Best                                          6.061 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═══════════════════════╡ All Y +MzB3 ╞═╗
║ Best                                          4.029 ║
║ Worst                                         0.000 ║
║ Total                                         0.950 ║
╠═╡ Cycles (-%) ╞═════════════════════╡ All Y +MzB3 ╞═╣
║ Best                                          3.810 ║
║ Worst                                        -0.211 ║
║ Total                                         0.025 ║
╠═╡ Ergs (-%) ╞═══════════════════════╡ All Y +MzB3 ╞═╣
║ Best                                          3.359 ║
║ Worst                                        -0.026 ║
║ Total                                         0.036 ║
╠══╡ Gas (-%) ╞═══════════════════════╡ All Y +MzB3 ╞═╣
║ Best                                          6.061 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═════════════════╡ Real life E +M3B3 ╞═╗
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Cycles (-%) ╞═══════════════╡ Real life E +M3B3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Ergs (-%) ╞═════════════════╡ Real life E +M3B3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠══╡ Gas (-%) ╞═════════════════╡ Real life E +M3B3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═════════════════╡ Real life E +MzB3 ╞═╗
║ Best                                          0.019 ║
║ Worst                                         0.000 ║
║ Total                                         0.004 ║
╠═╡ Cycles (-%) ╞═══════════════╡ Real life E +MzB3 ╞═╣
║ Best                                          0.055 ║
║ Worst                                         0.000 ║
║ Total                                         0.004 ║
╠═╡ Ergs (-%) ╞═════════════════╡ Real life E +MzB3 ╞═╣
║ Best                                          0.028 ║
║ Worst                                         0.000 ║
║ Total                                         0.001 ║
╠══╡ Gas (-%) ╞═════════════════╡ Real life E +MzB3 ╞═╣
║ Best                                          0.019 ║
║ Worst                                         0.000 ║
║ Total                                         0.004 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═════════════════╡ Real life Y +M3B3 ╞═╗
║ Best                                          0.894 ║
║ Worst                                         0.000 ║
║ Total                                         0.448 ║
╠═╡ Cycles (-%) ╞═══════════════╡ Real life Y +M3B3 ╞═╣
║ Best                                          1.677 ║
║ Worst                                         0.000 ║
║ Total                                         0.371 ║
╠═╡ Ergs (-%) ╞═════════════════╡ Real life Y +M3B3 ╞═╣
║ Best                                          1.337 ║
║ Worst                                         0.000 ║
║ Total                                         0.240 ║
╠══╡ Gas (-%) ╞═════════════════╡ Real life Y +M3B3 ╞═╣
║ Best                                          2.970 ║
║ Worst                                         0.000 ║
║ Total                                         0.421 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═════════════════╡ Real life Y +MzB3 ╞═╗
║ Best                                          0.912 ║
║ Worst                                         0.000 ║
║ Total                                         0.467 ║
╠═╡ Cycles (-%) ╞═══════════════╡ Real life Y +MzB3 ╞═╣
║ Best                                          1.989 ║
║ Worst                                         0.000 ║
║ Total                                         0.321 ║
╠═╡ Ergs (-%) ╞═════════════════╡ Real life Y +MzB3 ╞═╣
║ Best                                          1.407 ║
║ Worst                                         0.000 ║
║ Total                                         0.300 ║
╠══╡ Gas (-%) ╞═════════════════╡ Real life Y +MzB3 ╞═╣
║ Best                                          2.256 ║
║ Worst                                         0.000 ║
║ Total                                         0.436 ║
╚═════════════════════════════════════════════════════╝

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 30, 2025 •
edited
Loading

Target Mode Toolchain Environment Link
eravm E+M3B3_0.4 ir-llvm zk_evm Results
eravm E+M3B3_0.5 ir-llvm zk_evm Results
eravm E+M3B3_0.6 ir-llvm zk_evm Results
eravm E+M3B3_0.7 ir-llvm zk_evm Results
eravm E+M3B3_0.8 ir-llvm zk_evm Results
eravm E+MzB3_0.4 ir-llvm zk_evm Results
eravm E+MzB3_0.5 ir-llvm zk_evm Results
eravm E+MzB3_0.6 ir-llvm zk_evm Results
eravm E+MzB3_0.7 ir-llvm zk_evm Results
eravm E+MzB3_0.8 ir-llvm zk_evm Results
eravm Y+M3B3 ir-llvm zk_evm Results
eravm Y+MzB3 ir-llvm zk_evm Results
evm E+M3B3 ir-llvm EVMInterpreter Results
evm E+MzB3 ir-llvm EVMInterpreter Results
evm Y+M3B3 ir-llvm EVMInterpreter Results
evm Y+MzB3 ir-llvm EVMInterpreter Results
evm E+_0.8 solc EVMInterpreter Results
evm Y+ solc EVMInterpreter Results

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 30, 2025 •
edited
Loading

📊 Excel Report Available

Benchmarks measured for:

  • solx candidate version: solx, LLVM-based Solidity compiler for the EVM v0.1.1, LLVM revision: v1.0.2, LLVM build: 504b68b1255253dce82b1490722f08bae5102b85
  • solx ToT version: solx, LLVM-based Solidity compiler for the EVM v0.1.1, LLVM revision: v1.0.2, LLVM build: 76037970514f95ffb26a75cce06b7ac1b278c700
  • solx latest release version: solx, LLVM-based Solidity compiler for the EVM v0.1.1, LLVM revision: v1.0.2, LLVM build: b32c5ccab280fd4219e26aceb3f60f425e907498
  • solc version: 0.8.30

➡️ Download Excel Report

@akiramenai akiramenai force-pushed the dborisenkov-jumpior branch from d4710c8 to 758e87a Compare July 30, 2025 11:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 30, 2025 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

@akiramenai akiramenai force-pushed the dborisenkov-jumpior branch 2 times, most recently from e767ea6 to 7473e2b Compare July 30, 2025 14:54
@akiramenai akiramenai force-pushed the dborisenkov-jumpior branch 3 times, most recently from 3c84ace to b1a975a Compare August 31, 2025 11:05
@codecov Codecov
Copy link

codecov bot commented Aug 31, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 76.56250% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.07%. Comparing base (7603797) to head (504b68b).

Files with missing lines Patch % Lines
llvm/lib/Target/EVM/EVMPeephole.cpp 73.07% 8 Missing and 6 partials ⚠️
llvm/lib/Target/EVM/EVMTargetMachine.cpp 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #870      +/-   ##
==========================================
- Coverage   30.07%   30.07%   -0.01%     
==========================================
  Files        2441     2442       +1     
  Lines      807942   807953      +11     
  Branches   176474   176478       +4     
==========================================
- Hits       242975   242974       -1     
- Misses     522805   522807       +2     
- Partials    42162    42172      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@akiramenai akiramenai force-pushed the dborisenkov-jumpior branch 2 times, most recently from 4c5a22d to 0bc232d Compare August 31, 2025 13:49
@akiramenai
Revert "[EVM] Improve code generation for conditional jumps"
d97011a 
This reverts commit 1df3586.
@akiramenai
[EVM] NFC: Remove dead code from EVMLowerJumpUnless
c5c536d
@akiramenai
[EVM] Improve code generation for conditional jumps
8a59e3a 
The patch introduces a few SelectionDAG patterns to improve codegen for the
`br (brcond (setcc))` case. Additionally, due to the late expansion of
JUMP_UNLESS, the patch introduces a peephole pass that optimizes JUMPI
predicates:

* `ISZERO ISZERO` is folded to nothing
* `EQ ISZERO` is folded to `SUB`
* `SUB ISZERO` is folded to `EQ`
@akiramenai
[EVM] Support OR in conditional jump optimization
19cd9a6
@akiramenai
[EVM] O0 llc pipeline test
504b68b
@akiramenai akiramenai force-pushed the dborisenkov-jumpior branch from 0bc232d to 504b68b Compare August 31, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@akiramenai