-
Notifications
You must be signed in to change notification settings - Fork 24
[EVM] Add some opt passes before ISel #886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ With the latest revision this PR passed the C/C++ code formatter. |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #886 +/- ##
==========================================
+ Coverage 30.91% 30.95% +0.03%
==========================================
Files 2430 2430
Lines 806276 806292 +16
Branches 176487 176492 +5
==========================================
+ Hits 249277 249587 +310
+ Misses 513109 512792 -317
- Partials 43890 43913 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
📊 Excel Report Available Benchmarks measured for:
|
ea4251d
to
469549e
Compare
5c0d89b
to
8285739
Compare
8285739
to
3067157
Compare
5333ebb
to
438c23e
Compare
5a19d7c
to
d32fa10
Compare
📊 evm compiler-tester excel report Benchmarks measured for:
|
|
|
2bf6fe0
to
9ccfcb2
Compare
This includes early-cse, gvn, dse, simplifycfg and passes that optimize GEP instructions.
9ccfcb2
to
b7f3713
Compare
Code Review Checklist
Purpose
Ticket Number
Requirements
Implementation
Logic Errors and Bugs
code does not behave as intended?
that could break the code?
Error Handling and Logging
be added or removed?
written in a way that allows for easy
debugging?
Maintainability
Dependencies
Security
Performance
system performance?
performance of the code significantly?
Testing and Testability
that should be tested in addition?
Readability
smaller methods?
different function, method or variable names?
file/folder/package?
restructured to have a more intuitive control
flow?
better?
understandable?
Documentation
Best Practices
Experts' Opinion
expert or a usability expert, should look over
the code before it can be accepted?