Skip to content

Conversation

PavelKopyl
Copy link
Contributor

Code Review Checklist

Purpose

Ticket Number

Requirements

  • Have the requirements been met?
  • Have stakeholder(s) approved the change?

Implementation

  • Does this code change accomplish what it is supposed to do?
  • Can this solution be simplified?
  • Does this change add unwanted compile-time or run-time dependencies?
  • Could an additional framework, API, library, or service improve the solution?
  • Could we reuse part of LLVM instead of implementing the patch or a part of it?
  • Is the code at the right abstraction level?
  • Is the code modular enough?
  • Can a better solution be found in terms of maintainability, readability, performance, or security?
  • Does similar functionality already exist in the codebase? If yes, why isn’t it reused?
  • Are there any best practices, design patterns or language-specific patterns that could substantially improve this code?

Logic Errors and Bugs

  • Can you think of any use case in which the
    code does not behave as intended?
  • Can you think of any inputs or external events
    that could break the code?

Error Handling and Logging

  • Is error handling done the correct way?
  • Should any logging or debugging information
    be added or removed?
  • Are error messages user-friendly?
  • Are there enough log events and are they
    written in a way that allows for easy
    debugging?

Maintainability

  • Is the code easy to read?
  • Is the code not repeated (DRY Principle)?
  • Is the code method/class not too long?

Dependencies

  • Were updates to documentation, configuration, or readme files made as required by this change?
  • Are there any potential impacts on other parts of the system or backward compatibility?

Security

  • Does the code introduce any security vulnerabilities?

Performance

  • Do you think this code change decreases
    system performance?
  • Do you see any potential to improve the
    performance of the code significantly?

Testing and Testability

  • Is the code testable?
  • Have automated tests been added, or have related ones been updated to cover the change?
    • For changes to mutable state
  • Do tests reasonably cover the code change (unit/integration/system tests)?
    • Line Coverage
    • Region Coverage
    • Branch Coverage
  • Are there some test cases, input or edge cases
    that should be tested in addition?

Readability

  • Is the code easy to understand?
  • Which parts were confusing to you and why?
  • Can the readability of the code be improved by
    smaller methods?
  • Can the readability of the code be improved by
    different function, method or variable names?
  • Is the code located in the right
    file/folder/package?
  • Do you think certain methods should be
    restructured to have a more intuitive control
    flow?
  • Is the data flow understandable?
  • Are there redundant or outdated comments?
  • Could some comments convey the message
    better?
  • Would more comments make the code more
    understandable?
  • Could some comments be removed by making the code itself more readable?
  • Is there any commented-out code?
  • Have you run a spelling and grammar checker?

Documentation

  • Is there sufficient documentation?
  • Is the ReadMe.md file up to date?

Best Practices

  • Follow Single Responsibility principle?
  • Are different errors handled correctly?
  • Are errors and warnings logged?
  • Magic values avoided?
  • No unnecessary comments?
  • Minimal nesting used?

Experts' Opinion

  • Do you think a specific expert, like a security
    expert or a usability expert, should look over
    the code before it can be accepted?
  • Will this code change impact different teams, and should they review the change as well?

@PavelKopyl PavelKopyl marked this pull request as draft September 3, 2025 23:54
Copy link

github-actions bot commented Sep 3, 2025

✅ With the latest revision this PR passed the C/C++ code formatter.

Copy link

github-actions bot commented Sep 4, 2025

Results for: evm ir-llvm EVMInterpreter
╔═╡ Size (-%) ╞═══════════════════════╡ All E +M3B3 ╞═╗
║ Best                                         84.567 ║
║ Worst                                       -18.182 ║
║ Total                                         0.569 ║
╠═╡ Cycles (-%) ╞═════════════════════╡ All E +M3B3 ╞═╣
║ Best                                         71.154 ║
║ Worst                                        -5.505 ║
║ Total                                         0.015 ║
╠═╡ Ergs (-%) ╞═══════════════════════╡ All E +M3B3 ╞═╣
║ Best                                         50.607 ║
║ Worst                                        -3.821 ║
║ Total                                         0.042 ║
╠══╡ Gas (-%) ╞═══════════════════════╡ All E +M3B3 ╞═╣
║ Best                                         89.925 ║
║ Worst                                       -19.697 ║
║ Total                                         0.000 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═══════════════════════╡ All E +MzB3 ╞═╗
║ Best                                         16.521 ║
║ Worst                                       -11.480 ║
║ Total                                         0.050 ║
╠═╡ Cycles (-%) ╞═════════════════════╡ All E +MzB3 ╞═╣
║ Best                                         21.625 ║
║ Worst                                        -5.505 ║
║ Total                                         0.030 ║
╠═╡ Ergs (-%) ╞═══════════════════════╡ All E +MzB3 ╞═╣
║ Best                                         18.021 ║
║ Worst                                        -6.044 ║
║ Total                                         0.037 ║
╠══╡ Gas (-%) ╞═══════════════════════╡ All E +MzB3 ╞═╣
║ Best                                         16.804 ║
║ Worst                                       -11.703 ║
║ Total                                         0.000 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═══════════════════════╡ All Y +M3B3 ╞═╗
║ Best                                         27.851 ║
║ Worst                                        -4.631 ║
║ Total                                         0.227 ║
╠═╡ Cycles (-%) ╞═════════════════════╡ All Y +M3B3 ╞═╣
║ Best                                         25.433 ║
║ Worst                                        -5.763 ║
║ Total                                         0.042 ║
╠═╡ Ergs (-%) ╞═══════════════════════╡ All Y +M3B3 ╞═╣
║ Best                                         23.281 ║
║ Worst                                        -5.213 ║
║ Total                                         0.042 ║
╠══╡ Gas (-%) ╞═══════════════════════╡ All Y +M3B3 ╞═╣
║ Best                                         28.189 ║
║ Worst                                        -4.899 ║
║ Total                                         0.000 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═══════════════════════╡ All Y +MzB3 ╞═╗
║ Best                                          3.513 ║
║ Worst                                        -6.998 ║
║ Total                                         0.006 ║
╠═╡ Cycles (-%) ╞═════════════════════╡ All Y +MzB3 ╞═╣
║ Best                                         11.287 ║
║ Worst                                        -5.763 ║
║ Total                                         0.085 ║
╠═╡ Ergs (-%) ╞═══════════════════════╡ All Y +MzB3 ╞═╣
║ Best                                         11.581 ║
║ Worst                                        -3.511 ║
║ Total                                         0.072 ║
╠══╡ Gas (-%) ╞═══════════════════════╡ All Y +MzB3 ╞═╣
║ Best                                          9.740 ║
║ Worst                                        -7.437 ║
║ Total                                         0.000 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═════════════════╡ Real life E +M3B3 ╞═╗
║ Best                                          3.333 ║
║ Worst                                        -0.270 ║
║ Total                                         0.122 ║
╠═╡ Cycles (-%) ╞═══════════════╡ Real life E +M3B3 ╞═╣
║ Best                                          2.362 ║
║ Worst                                        -0.284 ║
║ Total                                         0.257 ║
╠═╡ Ergs (-%) ╞═════════════════╡ Real life E +M3B3 ╞═╣
║ Best                                          1.519 ║
║ Worst                                        -0.178 ║
║ Total                                         0.106 ║
╠══╡ Gas (-%) ╞═════════════════╡ Real life E +M3B3 ╞═╣
║ Best                                          2.912 ║
║ Worst                                        -0.280 ║
║ Total                                         0.111 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═════════════════╡ Real life E +MzB3 ╞═╗
║ Best                                          3.249 ║
║ Worst                                        -0.277 ║
║ Total                                         0.110 ║
╠═╡ Cycles (-%) ╞═══════════════╡ Real life E +MzB3 ╞═╣
║ Best                                          2.412 ║
║ Worst                                        -1.196 ║
║ Total                                         0.245 ║
╠═╡ Ergs (-%) ╞═════════════════╡ Real life E +MzB3 ╞═╣
║ Best                                          1.469 ║
║ Worst                                        -1.678 ║
║ Total                                         0.106 ║
╠══╡ Gas (-%) ╞═════════════════╡ Real life E +MzB3 ╞═╣
║ Best                                          3.045 ║
║ Worst                                        -0.282 ║
║ Total                                         0.105 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═════════════════╡ Real life Y +M3B3 ╞═╗
║ Best                                          2.861 ║
║ Worst                                        -0.007 ║
║ Total                                         0.110 ║
╠═╡ Cycles (-%) ╞═══════════════╡ Real life Y +M3B3 ╞═╣
║ Best                                          2.432 ║
║ Worst                                         0.000 ║
║ Total                                         0.272 ║
╠═╡ Ergs (-%) ╞═════════════════╡ Real life Y +M3B3 ╞═╣
║ Best                                          1.429 ║
║ Worst                                         0.000 ║
║ Total                                         0.108 ║
╠══╡ Gas (-%) ╞═════════════════╡ Real life Y +M3B3 ╞═╣
║ Best                                          2.683 ║
║ Worst                                        -0.007 ║
║ Total                                         0.096 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═════════════════╡ Real life Y +MzB3 ╞═╗
║ Best                                          2.991 ║
║ Worst                                         0.000 ║
║ Total                                         0.115 ║
╠═╡ Cycles (-%) ╞═══════════════╡ Real life Y +MzB3 ╞═╣
║ Best                                          2.089 ║
║ Worst                                         0.000 ║
║ Total                                         0.234 ║
╠═╡ Ergs (-%) ╞═════════════════╡ Real life Y +MzB3 ╞═╣
║ Best                                          1.465 ║
║ Worst                                         0.000 ║
║ Total                                         0.110 ║
╠══╡ Gas (-%) ╞═════════════════╡ Real life Y +MzB3 ╞═╣
║ Best                                          2.726 ║
║ Worst                                         0.000 ║
║ Total                                         0.104 ║
╚═════════════════════════════════════════════════════╝

Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 30.95%. Comparing base (0d19eb1) to head (b7f3713).

Files with missing lines Patch % Lines
llvm/lib/Target/EVM/EVMTargetMachine.cpp 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #886      +/-   ##
==========================================
+ Coverage   30.91%   30.95%   +0.03%     
==========================================
  Files        2430     2430              
  Lines      806276   806292      +16     
  Branches   176487   176492       +5     
==========================================
+ Hits       249277   249587     +310     
+ Misses     513109   512792     -317     
- Partials    43890    43913      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

github-actions bot commented Sep 4, 2025

📊 Excel Report Available

Benchmarks measured for:

  • solx candidate version: solx, LLVM-based Solidity compiler for the EVM v0.1.3, LLVM revision: v1.0.2, LLVM build: b7f37134bc747e62f1fbe5b62cc4deb8030c2a59
  • solx ToT version: solx, LLVM-based Solidity compiler for the EVM v0.1.3, LLVM revision: v1.0.2, LLVM build: 0d19eb1200af4d5a7d4bc855b6bd575aecce43f4
  • solx latest release version: solx, LLVM-based Solidity compiler for the EVM v0.1.2, LLVM revision: v1.0.2, LLVM build: aec023355f43d8ece02249360ba84e749fb5cb3f
  • solc version: 0.8.30

➡️ Download Excel Report

@PavelKopyl PavelKopyl force-pushed the kpv-add-opt-passes-berfore-isel branch 5 times, most recently from ea4251d to 469549e Compare September 8, 2025 15:14
@akiramenai akiramenai force-pushed the kpv-add-opt-passes-berfore-isel branch from 5c0d89b to 8285739 Compare September 13, 2025 14:07
@hedgar2017 hedgar2017 force-pushed the kpv-add-opt-passes-berfore-isel branch from 8285739 to 3067157 Compare September 16, 2025 12:47
@PavelKopyl PavelKopyl force-pushed the kpv-add-opt-passes-berfore-isel branch 2 times, most recently from 5333ebb to 438c23e Compare September 16, 2025 13:15
@PavelKopyl PavelKopyl force-pushed the kpv-add-opt-passes-berfore-isel branch from 5a19d7c to d32fa10 Compare October 1, 2025 18:59
Copy link

github-actions bot commented Oct 1, 2025

📊 evm compiler-tester excel report

Benchmarks measured for:

  • target machine: evm
  • toolchain: ir-llvm
  • environment: EVMInterpreter

➡️ Download Excel Report

Copy link

github-actions bot commented Oct 1, 2025

Project Mode Compiled (solc / solx / Total) Passed (solc / solx / Total)
openzeppelin default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 382 / 382 / 382 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 316 / 316 / 318
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 382 / 382 / 382 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 316 / 316 / 318
lil-web3 default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 20 / 20 / 20 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 68 / 68 / 68
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 20 / 20 / 20 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 66 / 68 / 68
maple-erc20 default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 28 / 28 / 28 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 29 / 29 / 29
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 28 / 28 / 28 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 29 / 29 / 29
diamonds default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 17 / 17 / 17 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 1 / 1 / 1
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 17 / 17 / 17 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 1 / 1 / 1
rollcall default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 64 / 64 / 64 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 14 / 14 / 14
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 64 / 64 / 64 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 14 / 14 / 14
playpen default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 43 / 43 / 43 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 6 / 6 / 9
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 43 / 43 / 43 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 6 / 6 / 9
solmate default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 60 / 60 / 60 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 55 / 55 / 69
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 60 / 60 / 60 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 55 / 55 / 69
prb-math default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 106 / 106 / 106 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 323 / 323 / 323
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 106 / 106 / 106 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 323 / 323 / 323
solady default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 208 / 208 / 208 🟥🟥🟥🟥🟥🟥🟥🟥🟥⬜ 1571 / 1553 / 1571
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 208 / 208 / 208 🟥🟥🟥🟥🟥🟥🟥🟥🟥⬜ 1571 / 1553 / 1571
unix default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 21 / 21 / 21 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 2 / 2 / 3
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 21 / 21 / 21 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 0 / 2 / 0
foundry-upgrades default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 22 / 22 / 22 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 3 / 3 / 3
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 22 / 22 / 22 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 3 / 3 / 3
art-gobblers default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 56 / 56 / 56 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 127 / 127 / 127
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 56 / 56 / 56 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 121 / 121 / 127
lens-core default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 320 / 320 / 320 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 0 / 1876 / 0
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 320 / 320 / 320 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 0 / 1877 / 0
balance-snapshot default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 20 / 20 / 20 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 5 / 5 / 5
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 20 / 20 / 20 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 5 / 5 / 5
diamond-foundry default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 26 / 26 / 26 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 40 / 40 / 44
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 26 / 26 / 26 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 40 / 40 / 44
forge-std default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 50 / 50 / 50 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 0 / 0 / 0
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 50 / 50 / 50 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 0 / 0 / 0
tokenlon default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 121 / 121 / 121 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 53 / 53 / 67
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 121 / 121 / 121 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 53 / 53 / 67
uniswap-v4 default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 160 / 160 / 160 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 598 / 598 / 598
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 160 / 160 / 160 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 598 / 598 / 598
beefy default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 164 / 164 / 164 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 2 / 2 / 34
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 164 / 164 / 164 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 2 / 2 / 34
gov-of-venice default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 25 / 25 / 25 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 25 / 25 / 26
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 25 / 25 / 25 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 24 / 25 / 26
cicada default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 23 / 23 / 23 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 0 / 546 / 0
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 23 / 23 / 23 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 0 / 546 / 0
lens-v3 default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 240 / 240 / 240 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 662 / 662 / 663
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 240 / 240 / 240 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 0 / 662 / 0
morpho-blue default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 74 / 74 / 74 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 145 / 145 / 145
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 74 / 74 / 74 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 145 / 145 / 145
aave-v3 default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 473 / 473 / 473 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 980 / 980 / 980
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 473 / 473 / 473 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 979 / 980 / 980

Copy link

github-actions bot commented Oct 1, 2025

Project Mode Compile (solx/solc/Δs/Δ%) Run (solx/solc/Δs/Δ%) Size warnings (solx/solc)
openzeppelin default 15.27s / 19.06s / -3.79s / -20% 📉 2.67s / 3.07s / -0.40s / -13% 📉 2 / 3
viaIR 16.08s / 60.56s / -44.49s / -73% 📉 2.69s / 3.42s / -0.73s / -21% 📉 2 / 3
lil-web3 default 2.78s / 2.43s / +0.35s / +15% 📈 0.17s / 0.16s / +0.01s / +8% 📈 0 / 0
viaIR 2.30s / 10.56s / -8.26s / -78% 📉 0.16s / 0.17s / -0.00s / -1% ➖ 1 / 1
maple-erc20 default 2.39s / 1.88s / +0.52s / +28% 📈 0.21s / 0.22s / -0.00s / -2% ➖ 0 / 0
viaIR 1.98s / 5.45s / -3.47s / -64% 📉 0.22s / 0.21s / +0.01s / +3% ➖ 0 / 0
diamonds default 2.20s / 1.08s / +1.12s / +103% 📈 0.54s / 0.52s / +0.02s / +5% ➖ 0 / 0
viaIR 1.73s / 2.75s / -1.01s / -37% 📉 0.55s / 0.52s / +0.03s / +5% 📈 0 / 0
rollcall default 3.58s / 3.31s / +0.27s / +8% 📈 0.23s / 0.23s / +0.00s / +1% ➖ 0 / 2
viaIR 3.05s / 13.53s / -10.48s / -77% 📉 0.22s / 0.22s / +0.00s / +2% ➖ 1 / 2
playpen default 3.42s / 2.35s / +1.08s / +46% 📈 0.24s / 0.23s / +0.01s / +7% 📈 0 / 6
viaIR 2.82s / 8.98s / -6.16s / -69% 📉 0.24s / 0.24s / +0.00s / +2% ➖ 0 / 6
solmate default 12.24s / 7.03s / +5.20s / +74% 📈 0.25s / 0.20s / +0.05s / +26% 📈 2 / 7
viaIR 6.66s / 43.33s / -36.68s / -85% 📉 0.20s / 0.19s / +0.01s / +6% 📈 4 / 9
prb-math default 11.26s / 10.06s / +1.21s / +12% 📈 0.28s / 0.28s / +0.00s / +0% ➖ 0 / 0
viaIR 11.55s / 42.02s / -30.47s / -73% 📉 0.29s / 0.28s / +0.01s / +3% ➖ 0 / 0
solady default 25.02s / 29.92s / -4.90s / -16% 📉 0.76s / 0.78s / -0.02s / -2% ➖ 19 / 21
viaIR 24.17s / 209.32s / -185.15s / -88% 📉 0.78s / 0.79s / -0.01s / -1% ➖ 25 / 22
unix default 2.61s / 1.68s / +0.93s / +55% 📈 0.19s / 0.19s / +0.00s / +1% ➖ 0 / 1
viaIR 2.10s / 4.50s / -2.40s / -53% 📉 0.20s / 0.62s / -0.42s / -67% 📉 0 / 0
foundry-upgrades default 1.34s / 0.97s / +0.36s / +37% 📈 0.17s / 0.17s / +0.00s / +1% ➖ 0 / 0
viaIR 1.12s / 2.62s / -1.51s / -57% 📉 0.17s / 0.17s / -0.01s / -3% ➖ 0 / 0
art-gobblers default 8.93s / 5.04s / +3.89s / +77% 📈 0.66s / 0.73s / -0.06s / -9% 📉 1 / 19
viaIR 6.66s / 25.94s / -19.28s / -74% 📉 0.65s / 0.71s / -0.05s / -8% 📉 1 / 22
lens-core default 113.95s / 11.90s / +102.04s / +857% 📈 3.85s / 14.52s / -10.67s / -73% 📉 85 / 0
viaIR 77.84s / 551.22s / -473.37s / -86% 📉 3.75s / 559.09s / -555.35s / -99% 📉 83 / 0
balance-snapshot default 2.32s / 0.92s / +1.40s / +152% 📈 0.15s / 0.15s / +0.01s / +3% ➖ 0 / 0
viaIR 1.88s / 3.09s / -1.20s / -39% 📉 0.15s / 0.14s / +0.01s / +3% ➖ 0 / 0
diamond-foundry default 3.20s / 2.30s / +0.90s / +39% 📈 0.14s / 0.14s / +0.00s / +2% ➖ 0 / 1
viaIR 1.91s / 6.75s / -4.83s / -72% 📉 0.15s / 0.14s / +0.01s / +6% 📈 0 / 0
forge-std default 10.34s / 8.07s / +2.27s / +28% 📈 0.57s / 0.67s / -0.10s / -15% 📉 7 / 7
viaIR 7.26s / 37.13s / -29.87s / -80% 📉 0.58s / 0.74s / -0.15s / -21% 📉 8 / 8
tokenlon default 18.19s / 19.34s / -1.15s / -6% 📉 0.31s / 0.31s / -0.01s / -2% ➖ 10 / 26
viaIR 12.18s / 95.58s / -83.41s / -87% 📉 0.30s / 0.32s / -0.02s / -5% 📉 12 / 28
uniswap-v4 default 22.34s / 18.51s / +3.83s / +21% 📈 2.72s / 2.74s / -0.02s / -1% ➖ 4 / 33
viaIR 16.21s / 101.96s / -85.74s / -84% 📉 2.72s / 2.77s / -0.05s / -2% ➖ 7 / 35
beefy default 16.83s / 20.99s / -4.16s / -20% 📉 0.63s / 0.63s / -0.00s / -0% ➖ 14 / 27
viaIR 14.65s / 101.95s / -87.30s / -86% 📉 0.63s / 0.64s / -0.00s / -1% ➖ 16 / 26
gov-of-venice default 5.21s / 3.65s / +1.57s / +43% 📈 0.44s / 0.54s / -0.10s / -18% 📉 2 / 10
viaIR 3.60s / 24.30s / -20.70s / -85% 📉 0.48s / 0.53s / -0.06s / -10% 📉 2 / 10
lens-v3 default 77.38s / 48.89s / +28.49s / +58% 📈 0.63s / 0.64s / -0.01s / -2% ➖ 32 / 60
viaIR 46.84s / 10.30s / +36.54s / +355% 📈 0.62s / 12.21s / -11.59s / -95% 📉 33 / 0
morpho-blue default 9.87s / 11.85s / -1.98s / -17% 📉 0.23s / 0.23s / -0.00s / -0% ➖ 6 / 34
viaIR 8.05s / 66.75s / -58.70s / -88% 📉 0.23s / 0.23s / +0.00s / +0% ➖ 9 / 33
aave-v3 default 217.18s / 116.64s / +100.53s / +86% 📈 1.66s / 1.72s / -0.07s / -4% ➖ 82 / 164
viaIR 127.83s / 1013.26s / -885.43s / -87% 📉 1.67s / 1.65s / +0.02s / +1% ➖ 84 / 164

@PavelKopyl PavelKopyl force-pushed the kpv-add-opt-passes-berfore-isel branch 3 times, most recently from 2bf6fe0 to 9ccfcb2 Compare October 3, 2025 14:45
@PavelKopyl PavelKopyl requested a review from akiramenai October 4, 2025 00:46
@PavelKopyl PavelKopyl marked this pull request as ready for review October 4, 2025 00:46
This includes early-cse, gvn, dse, simplifycfg and passes that
optimize GEP instructions.
@PavelKopyl PavelKopyl force-pushed the kpv-add-opt-passes-berfore-isel branch from 9ccfcb2 to b7f3713 Compare October 4, 2025 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant