Skip to content

[EVM] Combine signextend #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[EVM] Combine signextend #889

wants to merge 3 commits into from

Conversation

akiramenai
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2025 •
edited
Loading 

Results for: evm ir-llvm EVMInterpreter
╔═╡ Size (-%) ╞═══════════════════════╡ All E +M3B3 ╞═╗
║ Best                                         17.992 ║
║ Worst                                       -19.807 ║
║ Total                                        -0.136 ║
╠═╡ Cycles (-%) ╞═════════════════════╡ All E +M3B3 ╞═╣
║ Best                                         27.104 ║
║ Worst                                        -8.998 ║
║ Total                                         0.002 ║
╠═╡ Ergs (-%) ╞═══════════════════════╡ All E +M3B3 ╞═╣
║ Best                                          6.820 ║
║ Worst                                        -6.055 ║
║ Total                                        -0.005 ║
╠══╡ Gas (-%) ╞═══════════════════════╡ All E +M3B3 ╞═╣
║ Best                                         30.277 ║
║ Worst                                       -23.001 ║
║ Total                                        -0.000 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═══════════════════════╡ All E +MzB3 ╞═╗
║ Best                                         18.220 ║
║ Worst                                        -8.333 ║
║ Total                                        -0.052 ║
╠═╡ Cycles (-%) ╞═════════════════════╡ All E +MzB3 ╞═╣
║ Best                                         26.983 ║
║ Worst                                       -12.702 ║
║ Total                                        -0.001 ║
╠═╡ Ergs (-%) ╞═══════════════════════╡ All E +MzB3 ╞═╣
║ Best                                          6.671 ║
║ Worst                                        -6.975 ║
║ Total                                        -0.001 ║
╠══╡ Gas (-%) ╞═══════════════════════╡ All E +MzB3 ╞═╣
║ Best                                         29.645 ║
║ Worst                                       -15.278 ║
║ Total                                        -0.000 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═══════════════════════╡ All Y +M3B3 ╞═╗
║ Best                                         18.182 ║
║ Worst                                       -17.797 ║
║ Total                                        -0.195 ║
╠═╡ Cycles (-%) ╞═════════════════════╡ All Y +M3B3 ╞═╣
║ Best                                         28.131 ║
║ Worst                                       -18.239 ║
║ Total                                        -0.002 ║
╠═╡ Ergs (-%) ╞═══════════════════════╡ All Y +M3B3 ╞═╣
║ Best                                          7.681 ║
║ Worst                                       -17.687 ║
║ Total                                        -0.008 ║
╠══╡ Gas (-%) ╞═══════════════════════╡ All Y +M3B3 ╞═╣
║ Best                                         33.265 ║
║ Worst                                       -20.553 ║
║ Total                                        -0.000 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═══════════════════════╡ All Y +MzB3 ╞═╗
║ Best                                         18.400 ║
║ Worst                                        -9.395 ║
║ Total                                        -0.043 ║
╠═╡ Cycles (-%) ╞═════════════════════╡ All Y +MzB3 ╞═╣
║ Best                                         27.151 ║
║ Worst                                       -12.074 ║
║ Total                                        -0.002 ║
╠═╡ Ergs (-%) ╞═══════════════════════╡ All Y +MzB3 ╞═╣
║ Best                                          6.795 ║
║ Worst                                        -5.151 ║
║ Total                                        -0.002 ║
╠══╡ Gas (-%) ╞═══════════════════════╡ All Y +MzB3 ╞═╣
║ Best                                         29.857 ║
║ Worst                                       -14.536 ║
║ Total                                        -0.000 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═════════════════╡ Real life E +M3B3 ╞═╗
║ Best                                          0.315 ║
║ Worst                                         0.000 ║
║ Total                                         0.006 ║
╠═╡ Cycles (-%) ╞═══════════════╡ Real life E +M3B3 ╞═╣
║ Best                                          0.209 ║
║ Worst                                        -0.760 ║
║ Total                                         0.003 ║
╠═╡ Ergs (-%) ╞═════════════════╡ Real life E +M3B3 ╞═╣
║ Best                                          0.132 ║
║ Worst                                        -0.336 ║
║ Total                                         0.001 ║
╠══╡ Gas (-%) ╞═════════════════╡ Real life E +M3B3 ╞═╣
║ Best                                          0.319 ║
║ Worst                                        -0.649 ║
║ Total                                         0.006 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═════════════════╡ Real life E +MzB3 ╞═╗
║ Best                                          0.323 ║
║ Worst                                         0.000 ║
║ Total                                         0.007 ║
╠═╡ Cycles (-%) ╞═══════════════╡ Real life E +MzB3 ╞═╣
║ Best                                          0.206 ║
║ Worst                                        -0.752 ║
║ Total                                         0.003 ║
╠═╡ Ergs (-%) ╞═════════════════╡ Real life E +MzB3 ╞═╣
║ Best                                          0.128 ║
║ Worst                                        -0.334 ║
║ Total                                         0.001 ║
╠══╡ Gas (-%) ╞═════════════════╡ Real life E +MzB3 ╞═╣
║ Best                                          0.327 ║
║ Worst                                        -0.636 ║
║ Total                                         0.006 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═════════════════╡ Real life Y +M3B3 ╞═╗
║ Best                                          0.000 ║
║ Worst                                        -3.950 ║
║ Total                                        -0.086 ║
╠═╡ Cycles (-%) ╞═══════════════╡ Real life Y +M3B3 ╞═╣
║ Best                                          0.779 ║
║ Worst                                        -1.257 ║
║ Total                                         0.015 ║
╠═╡ Ergs (-%) ╞═════════════════╡ Real life Y +M3B3 ╞═╣
║ Best                                          0.491 ║
║ Worst                                        -1.553 ║
║ Total                                        -0.016 ║
╠══╡ Gas (-%) ╞═════════════════╡ Real life Y +M3B3 ╞═╣
║ Best                                          0.834 ║
║ Worst                                        -4.001 ║
║ Total                                        -0.072 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═════════════════╡ Real life Y +MzB3 ╞═╗
║ Best                                          0.000 ║
║ Worst                                        -0.325 ║
║ Total                                        -0.008 ║
╠═╡ Cycles (-%) ╞═══════════════╡ Real life Y +MzB3 ╞═╣
║ Best                                          0.097 ║
║ Worst                                        -0.500 ║
║ Total                                        -0.002 ║
╠═╡ Ergs (-%) ╞═════════════════╡ Real life Y +MzB3 ╞═╣
║ Best                                          0.061 ║
║ Worst                                        -0.227 ║
║ Total                                        -0.001 ║
╠══╡ Gas (-%) ╞═════════════════╡ Real life Y +MzB3 ╞═╣
║ Best                                          0.164 ║
║ Worst                                        -0.373 ║
║ Total                                        -0.006 ║
╚═════════════════════════════════════════════════════╝

@codecov Codecov
Copy link

codecov bot commented Sep 7, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.08%. Comparing base (d719238) to head (9540472).

Files with missing lines Patch % Lines
llvm/lib/Target/EVM/EVMTargetTransformInfo.cpp 69.23% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #889      +/-   ##
==========================================
+ Coverage   30.07%   30.08%   +0.01%     
==========================================
  Files        2441     2441              
  Lines      807942   807955      +13     
  Branches   176474   176477       +3     
==========================================
+ Hits       242962   243085     +123     
+ Misses     522806   522695     -111     
- Partials    42174    42175       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2025 •
edited
Loading

📊 Excel Report Available

Benchmarks measured for:

  • solx candidate version: solx, LLVM-based Solidity compiler for the EVM v0.1.1, LLVM revision: v1.0.2, LLVM build: 954047250508a03cd6eca439d58cc2f6c2fad625
  • solx ToT version: solx, LLVM-based Solidity compiler for the EVM v0.1.1, LLVM revision: v1.0.2, LLVM build: d7192387c3fb7594be00716a6f56b9635d0ea4d2
  • solx latest release version: solx, LLVM-based Solidity compiler for the EVM v0.1.1, LLVM revision: v1.0.2, LLVM build: b32c5ccab280fd4219e26aceb3f60f425e907498
  • solc version: 0.8.30

➡️ Download Excel Report

vladimirradosavljevic and others added 2 commits September 7, 2025 21:12
@vladimirradosavljevic @akiramenai
[EVM] Unfold signextend(c, x) -> ashr(shl(x, 256 - (c + 1) * 8), 256 …
5927bed 
…- (c + 1) * 8)

This transform does unfold to canonical InstCombine form,
instead to sext(trunc(x, (c + 1) * 8), 256).
Unfold signextend to LLVM instructions, iff c is constant,
so LLVM can optimize it better. Do the folding back just
before ISel, since we can do cross BB boundaries.

Signed-off-by: Vladimir Radosavljevic <[email protected]>
@akiramenai
- optimizeAshr
9540472
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akiramenai @vladimirradosavljevic